Do not store the repository name in RepoSpec
#21026
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fmeum
force-pushed
the
20997-repo-spec
branch
13 times, most recently
from
69b1892 to
537e9b1
Compare
fmeum
commented
Jan 25, 2024
fmeum
commented
Jan 25, 2024
fmeum
force-pushed
the
20997-repo-spec
branch
2 times, most recently
from
c4f9da7 to
a4f103a
Compare
github-actions
bot
added
team-ExternalDeps
fmeum
force-pushed
the
20997-repo-spec
branch
from
7fff96f to
a4f103a
Compare
Wyverald
reviewed
Jan 25, 2024
Member
Wyverald
left a comment
Wyverald
left a comment
There was a problem hiding this comment.
looks good to me -- will let @meteorcloudy answer the outstanding questions
src/main/java/com/google/devtools/build/lib/bazel/bzlmod/Registry.java
Outdated
Show resolved
Hide resolved
fmeum
force-pushed
the
20997-repo-spec
branch
from
a4f103a to
03d663c
Compare
meteorcloudy
requested changes
Jan 26, 2024
fmeum
force-pushed
the
20997-repo-spec
branch
from
bd76f92 to
625ecee
Compare
meteorcloudy
requested changes
Jan 26, 2024
fmeum
force-pushed
the
20997-repo-spec
branch
from
a1f06f4 to
1b3f7db
Compare
Member
|
Hi @fmeum, The above PR is awaiting to merge, Can you please take a look and also resolve the conflicts. Thanks! |
fmeum
force-pushed
the
20997-repo-spec
branch
from
6f43e8d to
83ec486
Compare
The name can instead be set centrally in `BzlmodRepoRuleFunction`. This removes some glue code and paves the way for rewriting canonical repo names based on knowledge of the full dep graph.
fmeum
force-pushed
the
20997-repo-spec
branch
from
ca59bac to
cb833cd
Compare
Collaborator
Author
|
The r_j_e update introduced more special cases for the lockfile update hack that I could't figure out how to handle, so I just built backwards compatibility into Bazel instead. Do you think that's reasonable? |
meteorcloudy
approved these changes
Feb 1, 2024
Member
meteorcloudy
left a comment
meteorcloudy
left a comment
There was a problem hiding this comment.
I think this is even better! Thanks!
meteorcloudy
approved these changes
Feb 1, 2024
github-actions
bot
removed
the
awaiting-PR-merge
Collaborator
Author
|
@bazel-io fork 7.1.0 |
iancha1992
pushed a commit
to iancha1992/bazel
that referenced
this pull request
Feb 5, 2024
The name can instead be set centrally in `BzlmodRepoRuleFunction`. This removes some unnecessary glue code and paves the way for rewriting canonical repo names based on knowledge of the full dep graph. Work towards bazelbuild#20997 Closes bazelbuild#21026. PiperOrigin-RevId: 604256186 Change-Id: Ia49123f016d1512074b04ec458f017f4bbb88233
iancha1992
pushed a commit
to iancha1992/bazel
that referenced
this pull request
Feb 5, 2024
The name can instead be set centrally in `BzlmodRepoRuleFunction`. This removes some unnecessary glue code and paves the way for rewriting canonical repo names based on knowledge of the full dep graph. Work towards bazelbuild#20997 Closes bazelbuild#21026. PiperOrigin-RevId: 604256186 Change-Id: Ia49123f016d1512074b04ec458f017f4bbb88233
Wyverald
pushed a commit
that referenced
this pull request
Feb 6, 2024
The name can instead be set centrally in `BzlmodRepoRuleFunction`. This removes some unnecessary glue code and paves the way for rewriting canonical repo names based on knowledge of the full dep graph. Work towards #20997 Closes #21026. PiperOrigin-RevId: 604256186 Change-Id: Ia49123f016d1512074b04ec458f017f4bbb88233
github-merge-queue bot
pushed a commit
that referenced
this pull request
Feb 6, 2024
The name can instead be set centrally in `BzlmodRepoRuleFunction`. This removes some unnecessary glue code and paves the way for rewriting canonical repo names based on knowledge of the full dep graph. Work towards #20997 Closes #21026. PiperOrigin-RevId: 604256186 Change-Id: Ia49123f016d1512074b04ec458f017f4bbb88233 Co-authored-by: Fabian Meumertzheim <[email protected]>
Member
|
We should have updated the lockfile version in this change. Otherwise people getting the following error after switching from Bazel@HEAD and Bazel 7.x with lockfile enabled |
Member
|
@SalmaSamy is sending a change to bump the lock file version. |
Collaborator
Author
|
Thanks for catching this, I only thought about forward compatibility but never considered the other direction. @SalmaSamy #21035 will bump the lock file version anyway. I will try to fix the remaining test today. |
Member
|
The changes in this PR have been included in Bazel 7.1.0 RC1. Please test out the release candidate and report any issues as soon as possible. If you're using Bazelisk, you can point to the latest RC by setting USE_BAZEL_VERSION=last_rc. |
malt3
added a commit
to malt3/nixpkgs
that referenced
this pull request
May 24, 2024
The new lockfile format 6 drops the "name" attribute of each repoSpec. See also: bazelbuild/bazel#21026 This prevents the builder from effectively the deps using requiredDepNamePredicate. Instead, we now generate names from other metadata.
malt3
added a commit
to malt3/nixpkgs
that referenced
this pull request
May 30, 2024
The new lockfile format 6 drops the "name" attribute of each repoSpec. See also: bazelbuild/bazel#21026 This prevents the builder from effectively the deps using requiredDepNamePredicate. Instead, we now generate names from other metadata.
layus
pushed a commit
to NixOS/nixpkgs
that referenced
this pull request
Jun 3, 2024
* bazel_7: 7.1.0 -> 7.1.2 * bazel_7: update lockfiles * bazel_7: upgrade lockfile format for versions > 3 The new lockfile format 6 drops the "name" attribute of each repoSpec. See also: bazelbuild/bazel#21026 This prevents the builder from effectively the deps using requiredDepNamePredicate. Instead, we now generate names from other metadata.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The name can instead be set centrally in
BzlmodRepoRuleFunction. This removes some unnecessary glue code and paves the way for rewriting canonical repo names based on knowledge of the full dep graph.Work towards #20997