Disregard WORKSPACE while verifying lockfile repo mapping entries in extension eval #20982
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…extension eval See code comment and linked issue for more information. Fixes #20942.
github-actions
bot
added
team-ExternalDeps
fmeum
approved these changes
Jan 22, 2024
src/main/java/com/google/devtools/build/lib/bazel/bzlmod/SingleExtensionEvalFunction.java
Outdated
Show resolved
Hide resolved
fmeum
approved these changes
Jan 22, 2024
Wyverald
added
awaiting-PR-merge
meteorcloudy
approved these changes
Jan 23, 2024
Member
meteorcloudy
left a comment
meteorcloudy
left a comment
There was a problem hiding this comment.
Nice team work, thanks everyone!
Member
|
I wonder if we need another patch release for this issue? Or should we just go with 7.1.0? |
github-actions
bot
removed
the
awaiting-PR-merge
bazel-io
pushed a commit
to bazel-io/bazel
that referenced
this pull request
Jan 23, 2024
…extension eval See code comment and linked issue for more information. Fixes bazelbuild#20942. Closes bazelbuild#20982. PiperOrigin-RevId: 600856392 Change-Id: I5b8a0ed3a38e37ab51ffb49b19a59f2e161b9a33
iancha1992
pushed a commit
that referenced
this pull request
Jan 23, 2024
…ries in extension eval (#21003) See code comment and linked issue for more information. Fixes #20942. Closes #20982. Commit 21508b1 PiperOrigin-RevId: 600856392 Change-Id: I5b8a0ed3a38e37ab51ffb49b19a59f2e161b9a33 --------- Co-authored-by: Xdng Yng <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See code comment and linked issue for more information.
Fixes #20942.