Introduce --default_test_resources flag #20839
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AlessandroPatti
requested review from
aranguyen
and removed request for
a team
github-actions
bot
added
team-Configurability
AlessandroPatti
force-pushed
the
apatti/19679/test-resources
branch
from
4b36c36 to
5355c30
Compare
AlessandroPatti
force-pushed
the
apatti/19679/test-resources
branch
from
5355c30 to
0bff9cd
Compare
meisterT
added
team-Performance
Member
zhengwei143
reviewed
Jan 24, 2024
src/main/java/com/google/devtools/build/lib/analysis/test/TestConfiguration.java
Outdated
Show resolved
Hide resolved
src/main/java/com/google/devtools/build/lib/analysis/test/TestConfiguration.java
Outdated
Show resolved
Hide resolved
src/main/java/com/google/devtools/build/lib/analysis/test/TestConfiguration.java
Outdated
Show resolved
Hide resolved
src/main/java/com/google/devtools/build/lib/analysis/test/TestConfiguration.java
Outdated
Show resolved
Hide resolved
Contributor
There was a problem hiding this comment.
Do add another test with flags with duplicate resources to test the behavior of how they override each other.
Contributor
Author
There was a problem hiding this comment.
The existing test already covers that: cpu is first set to 1,2,3,4 and then to 5
Contributor
There was a problem hiding this comment.
Missed that one :) thanks for pointing out
AlessandroPatti
changed the title
zhengwei143
approved these changes
Jan 30, 2024
zhengwei143
reviewed
Jan 30, 2024
src/test/java/com/google/devtools/build/lib/rules/test/TestTargetPropertiesTest.java
Outdated
Show resolved
Hide resolved
github-actions
bot
removed
the
awaiting-review
Contributor
|
Sorry this took a while, some internal tests made it annoying to push through. Thanks for your contribution! |
Contributor
|
@bazel-io flag |
bazel-io
added
the
potential release blocker
Member
|
@bazel-io fork 7.1.0 |
bazel-io
removed
the
potential release blocker
bazel-io
pushed a commit
to bazel-io/bazel
that referenced
this pull request
Feb 12, 2024
Add `--default_test_resources=<resource>=<value(s)>` that allows setting the default resource utilization for tests. The flag follow a syntax simialar to `--local_resources=<resource>=<value>`, in that it allow assigning different resource types, and `--test_timeout=<value(s)>`, which accepts either 1 or 4 intergers to assign to all test sizes or to each individually. Relates to bazelbuild#19679 Closes bazelbuild#20839. PiperOrigin-RevId: 606233269 Change-Id: Ia53e42820ba9aa646b0600fe4e9f95f146d7b2b9
iancha1992
pushed a commit
to bazel-io/bazel
that referenced
this pull request
Feb 14, 2024
Add `--default_test_resources=<resource>=<value(s)>` that allows setting the default resource utilization for tests. The flag follow a syntax simialar to `--local_resources=<resource>=<value>`, in that it allow assigning different resource types, and `--test_timeout=<value(s)>`, which accepts either 1 or 4 intergers to assign to all test sizes or to each individually. Relates to bazelbuild#19679 Closes bazelbuild#20839. PiperOrigin-RevId: 606233269 Change-Id: Ia53e42820ba9aa646b0600fe4e9f95f146d7b2b9
github-merge-queue bot
pushed a commit
that referenced
this pull request
Feb 15, 2024
Add `--default_test_resources=<resource>=<value(s)>` that allows setting the default resource utilization for tests. The flag follow a syntax simialar to `--local_resources=<resource>=<value>`, in that it allow assigning different resource types, and `--test_timeout=<value(s)>`, which accepts either 1 or 4 intergers to assign to all test sizes or to each individually. Relates to #19679 Closes #20839. Commit 0c5b6e8 PiperOrigin-RevId: 606233269 Change-Id: Ia53e42820ba9aa646b0600fe4e9f95f146d7b2b9 Co-authored-by: Alessandro Patti <[email protected]>
AlessandroPatti
added a commit
to AlessandroPatti/bazel
that referenced
this pull request
Feb 19, 2024
Add `--default_test_resources=<resource>=<value(s)>` that allows setting the default resource utilization for tests. The flag follow a syntax simialar to `--local_resources=<resource>=<value>`, in that it allow assigning different resource types, and `--test_timeout=<value(s)>`, which accepts either 1 or 4 intergers to assign to all test sizes or to each individually. Relates to bazelbuild#19679 Closes bazelbuild#20839. PiperOrigin-RevId: 606233269 Change-Id: Ia53e42820ba9aa646b0600fe4e9f95f146d7b2b9
apattidb
pushed a commit
to databricks/bazel
that referenced
this pull request
Feb 20, 2024
Add `--default_test_resources=<resource>=<value(s)>` that allows setting the default resource utilization for tests. The flag follow a syntax simialar to `--local_resources=<resource>=<value>`, in that it allow assigning different resource types, and `--test_timeout=<value(s)>`, which accepts either 1 or 4 intergers to assign to all test sizes or to each individually. Relates to bazelbuild#19679 Closes bazelbuild#20839. PiperOrigin-RevId: 606233269 Change-Id: Ia53e42820ba9aa646b0600fe4e9f95f146d7b2b9
Member
|
The changes in this PR have been included in Bazel 7.1.0 RC1. Please test out the release candidate and report any issues as soon as possible. If you're using Bazelisk, you can point to the latest RC by setting USE_BAZEL_VERSION=last_rc. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add
--default_test_resources=<resource>=<value(s)>that allows setting the default resource utilization for tests. The flag follow a syntax simialar to--local_resources=<resource>=<value>, in that it allow assigning different resource types, and--test_timeout=<value(s)>, which accepts either 1 or 4 intergers to assign to all test sizes or to each individually.Relates to #19679