Skip to content

Reenable C++ tests on Mac #20784

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
comius wants to merge 4 commits into from
Closed

Reenable C++ tests on Mac #20784

comius wants to merge 4 commits into from

Conversation

@comius
Copy link
Contributor

@comius comius commented Jan 8, 2024

No description provided.

@comius comius requested a review from meteorcloudy January 9, 2024 08:55
@comius comius marked this pull request as ready for review January 9, 2024 08:55
@comius comius requested a review from oquenchil as a code owner January 9, 2024 08:55
@github-actions github-actions bot added team-Rules-CPP Issues for C++ rules awaiting-review PR is awaiting review from an assigned reviewer labels Jan 9, 2024
@comius comius removed the request for review from oquenchil January 9, 2024 08:57
meteorcloudy
meteorcloudy approved these changes Jan 9, 2024
View reviewed changes
Copy link
Member

@meteorcloudy meteorcloudy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

@meteorcloudy meteorcloudy added awaiting-PR-merge PR has been approved by a reviewer and is ready to be merge internally and removed awaiting-review PR is awaiting review from an assigned reviewer labels Jan 9, 2024
@github-actions github-actions bot removed the awaiting-PR-merge PR has been approved by a reviewer and is ready to be merge internally label Jan 10, 2024
meteorcloudy pushed a commit to meteorcloudy/bazel that referenced this pull request Feb 21, 2024
@comius @meteorcloudy
Reenable C++ tests on Mac
dfe70fa 
Closes bazelbuild#20784.

PiperOrigin-RevId: 597193470
Change-Id: Ia84f05a4704d35ab65ab68ce514e474900091d08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@meteorcloudy meteorcloudy meteorcloudy approved these changes

@oquenchil oquenchil oquenchil approved these changes

Assignees

No one assigned

Labels

team-Rules-CPP Issues for C++ rules

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@comius @meteorcloudy @oquenchil