Reenable import_deps_checker tests in Bazel #20655
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
team-Rules-Java
fmeum
force-pushed
the
8162-fix-import-deps-checker-tests
branch
3 times, most recently
from
438b0d2 to
0f5e983
Compare
Collaborator
Author
|
@cushon The darwin runner failures seem to be unrelated and also affect other PRs. |
meteorcloudy
approved these changes
Dec 22, 2023
Member
|
We are upgrading our macOS machines this week, sorry for those CI failures. |
cushon
approved these changes
Dec 22, 2023
src/java_tools/import_deps_checker/javatests/com/google/devtools/build/importdeps/BUILD
Outdated
Show resolved
Hide resolved
cushon
approved these changes
Dec 22, 2023
sgowroji
added
awaiting-user-response
fmeum
force-pushed
the
8162-fix-import-deps-checker-tests
branch
2 times, most recently
from
b67c7fa to
c96dbb3
Compare
Collaborator
Author
|
@sgowroji I fixed the tests by rebasing. |
sgowroji
added
awaiting-review
meteorcloudy
added
awaiting-PR-merge
A compatible JDK 8 is fetched via `remote_java_repository`. Requires fixing paths in golden files to not contain `third_party/bazel/` as well as the expected exit code of the `MethodHandle#invoke` test, which is expected to pass.
fmeum
force-pushed
the
8162-fix-import-deps-checker-tests
branch
from
c96dbb3 to
d80ec92
Compare
Collaborator
Author
|
@meteorcloudy I resolved the conflict in the lockfile. |
meteorcloudy
approved these changes
Jan 10, 2024
Collaborator
Author
|
@meteorcloudy Friendly ping |
Member
|
@iancha1992 @sgowroji How is this one ignored? Anything wrong with your filter for PRs ready to be imported? |
cushon
reviewed
Jan 29, 2024
...java_tools/import_deps_checker/javatests/com/google/devtools/build/importdeps/golden_test.sh
Show resolved
Hide resolved
Contributor
There was an import in progress as cl/597295954, but it was blocked on test failures. |
Member
Looks like the tests are now going through after your changes. I'll try to merge then now. Can you LGTM cl/597295954 @meteorcloudy cc: @fmeum |
github-actions
bot
removed
the
awaiting-PR-merge
meteorcloudy
pushed a commit
to meteorcloudy/bazel
that referenced
this pull request
Feb 21, 2024
A compatible JDK 8 is fetched via `remote_java_repository`. Requires fixing paths in golden files to not contain `third_party/bazel/` as well as the expected exit code of the `MethodHandle#invoke` test, which is expected to pass. Fixes bazelbuild#8162 Closes bazelbuild#20655. PiperOrigin-RevId: 602641568 Change-Id: I54ec568d981e3bd27caab9e24c0c9eb2a25c6372
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A compatible JDK 8 is fetched via
remote_java_repository. Requires fixing paths in golden files to not containthird_party/bazel/as well as the expected exit code of theMethodHandle#invoketest, which is expected to pass.Fixes #8162