Attempt to make main repo mapping inverse more efficient #20617
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
awaiting-review
Member
Author
|
Not completely sold on this, btw. But it's the path of least resistance (regarding code changes). |
Member
Author
|
cc @JohnRambo |
fmeum
approved these changes
Dec 19, 2023
src/main/java/com/google/devtools/build/lib/cmdline/RepositoryMapping.java
Show resolved
Hide resolved
During `bazel query`, `Label#getDisplayForm(mainRepoMapping)` might be called many many times. We can optimize for that case without sacrificing too much memory by computing a reverse mapping for the main repo mapping only. Fixes #20613. Closes #20617. PiperOrigin-RevId: 592297440 Change-Id: Iaaa709a51fe39556f03408080c1fe5e73689b761
Wyverald
force-pushed
the
wyv-repo-mapping-inverse
branch
from
83fd8c7 to
e1726e2
Compare
|
Thanks @Wyverald for a quick fix. FWIW I built bazel from your branch and confirmed this works on our repo. |
iancha1992
added
the
team-ExternalDeps
Wyverald
added
awaiting-PR-merge
github-actions
bot
removed
the
awaiting-PR-merge
bazel-io
pushed a commit
to bazel-io/bazel
that referenced
this pull request
Dec 20, 2023
During `bazel query`, `Label#getDisplayForm(mainRepoMapping)` might be called many many times. We can optimize for that case without sacrificing too much memory by computing a reverse mapping for the main repo mapping only. Fixes bazelbuild#20613. Closes bazelbuild#20617. PiperOrigin-RevId: 592607904 Change-Id: Iaaa709a51fe39556f03408080c1fe5e73689b761
Wyverald
added a commit
that referenced
this pull request
Dec 20, 2023
) During `bazel query`, `Label#getDisplayForm(mainRepoMapping)` might be called many many times. We can optimize for that case without sacrificing too much memory by computing a reverse mapping for the main repo mapping only. Fixes #20613. Closes #20617. Commit d9169ab PiperOrigin-RevId: 592607904 Change-Id: Iaaa709a51fe39556f03408080c1fe5e73689b761 Co-authored-by: Googler <[email protected]>
bazel-io
pushed a commit
to bazel-io/bazel
that referenced
this pull request
Dec 21, 2023
During `bazel query`, `Label#getDisplayForm(mainRepoMapping)` might be called many many times. We can optimize for that case without sacrificing too much memory by computing a reverse mapping for the main repo mapping only. Fixes bazelbuild#20613. Closes bazelbuild#20617. PiperOrigin-RevId: 592607904 Change-Id: Iaaa709a51fe39556f03408080c1fe5e73689b761
github-merge-queue bot
pushed a commit
that referenced
this pull request
Jan 4, 2024
) During `bazel query`, `Label#getDisplayForm(mainRepoMapping)` might be called many many times. We can optimize for that case without sacrificing too much memory by computing a reverse mapping for the main repo mapping only. Fixes #20613. Closes #20617. Commit d9169ab PiperOrigin-RevId: 592607904 Change-Id: Iaaa709a51fe39556f03408080c1fe5e73689b761 Co-authored-by: Googler <[email protected]> Co-authored-by: Ian (Hee) Cha <[email protected]> Co-authored-by: Xùdōng Yáng <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #20613