python: make incompatible_python_disallow_native_rules work for top-level external repo targets #20516
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rickeylev
force-pushed
the
external.repo.py.disallow.native
branch
3 times, most recently
from
ef5a377 to
afc9170
Compare
…mpty package This basically makes it usable with the downloaded runtimes rules_python makes available. The issue was the code to construct the label was leaving a trailing "/" when the the target being checked at the root of the workspace. To fix, just omit the trailing slash when the package name is empty to prevent the trailing slash. Work towards bazelbuild#17773
rickeylev
force-pushed
the
external.repo.py.disallow.native
branch
from
afc9170 to
c5f6e2f
Compare
bazel-io
pushed a commit
to bazel-io/bazel
that referenced
this pull request
Jan 17, 2024
…evel external repo targets This basically makes it usable with the downloaded runtimes rules_python makes available, which reference their runtimes as e.g. `@python_3_11//:python`. The issue was the code to construct the label was leaving a trailing "/" when the the target being checked at the root of the workspace. To fix, just omit the trailing slash when the package name is empty to prevent the trailing slash. Work towards bazelbuild#17773 Closes bazelbuild#20516 PiperOrigin-RevId: 591053422 Change-Id: I7790df2db10278844ae2b36cfe671de03164972f
github-merge-queue bot
pushed a commit
that referenced
this pull request
Jan 17, 2024
…or top-level external repo targets (#20923) This basically makes it usable with the downloaded runtimes rules_python makes available, which reference their runtimes as e.g. `@python_3_11//:python`. The issue was the code to construct the label was leaving a trailing "/" when the the target being checked at the root of the workspace. To fix, just omit the trailing slash when the package name is empty to prevent the trailing slash. Work towards #17773 Closes #20516 Commit 1533cd1 PiperOrigin-RevId: 591053422 Change-Id: I7790df2db10278844ae2b36cfe671de03164972f Co-authored-by: Richard Levasseur <[email protected]>
Member
|
The changes in this PR have been included in Bazel 7.1.0 RC1. Please test out the release candidate and report any issues as soon as possible. If you're using Bazelisk, you can point to the latest RC by setting USE_BAZEL_VERSION=last_rc. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This basically makes it usable with the downloaded runtimes rules_python makes available,
which reference their runtimes as e.g.
@python_3_11//:python.The issue was the code to construct the label was leaving a trailing "/" when the the target being checked at the root of the workspace. To fix, just omit the trailing slash when the package name is empty to prevent the trailing slash.
Work towards #17773