python: rules_python 0.22.0 -> 0.22.1 soas to register Python toolchain by default #20514
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rickeylev
force-pushed
the
register.default.py.toolchain
branch
2 times, most recently
from
99dac59 to
1e22f85
Compare
A regression from upgrading to rules_python 0.22.0 is that a Python toolchain is no longer registered by default (the prior 0.4.0 version registered the "autodetecting" toolchain). Subsequent versions of rules_python (0.23.0 or later) register a toolchain by default again, but it's a downloaded runtime, which makes upgrading more involved. Instead, make the bazel_tools module register the "autodetecting" toolchain to restore the rules_python 0.4.0 behavior. This should suffice bazel_tools is upgraded to 0.23.0 or later.
rickeylev
force-pushed
the
register.default.py.toolchain
branch
from
1e22f85 to
b7d572f
Compare
rickeylev
changed the title
meteorcloudy
pushed a commit
to meteorcloudy/bazel
that referenced
this pull request
Feb 15, 2024
… toolchain by default A regression from upgrading to rules_python 0.22.0 is that a Python toolchain is no longer registered by default (the prior 0.4.0 version registered the "autodetecting" toolchain). Subsequent versions of rules_python (0.23.0 or later) register a toolchain by default again, but it's a downloaded runtime, which makes upgrading more involved. To fix, upgrade to 0.22.1, which registers the autodetecting toolchain. This restores the rules_python 0.4.0 behavior and should suffice until bazel_tools is upgraded to 0.23.0 or later. Fixes bazelbuild#20458 Closes bazelbuild#20514 PiperOrigin-RevId: 592578175 Change-Id: I707a4c96829063536f81cc10e144652102da1e7e
meteorcloudy
pushed a commit
to meteorcloudy/bazel
that referenced
this pull request
Feb 15, 2024
… toolchain by default A regression from upgrading to rules_python 0.22.0 is that a Python toolchain is no longer registered by default (the prior 0.4.0 version registered the "autodetecting" toolchain). Subsequent versions of rules_python (0.23.0 or later) register a toolchain by default again, but it's a downloaded runtime, which makes upgrading more involved. To fix, upgrade to 0.22.1, which registers the autodetecting toolchain. This restores the rules_python 0.4.0 behavior and should suffice until bazel_tools is upgraded to 0.23.0 or later. Fixes bazelbuild#20458 Closes bazelbuild#20514 PiperOrigin-RevId: 592578175 Change-Id: I707a4c96829063536f81cc10e144652102da1e7e
github-merge-queue bot
pushed a commit
that referenced
this pull request
Feb 15, 2024
… toolchain by default (#21369) A regression from upgrading to rules_python 0.22.0 is that a Python toolchain is no longer registered by default (the prior 0.4.0 version registered the "autodetecting" toolchain). Subsequent versions of rules_python (0.23.0 or later) register a toolchain by default again, but it's a downloaded runtime, which makes upgrading more involved. To fix, upgrade to 0.22.1, which registers the autodetecting toolchain. This restores the rules_python 0.4.0 behavior and should suffice until bazel_tools is upgraded to 0.23.0 or later. Fixes #20458 Closes #20514 PiperOrigin-RevId: 592578175 Change-Id: I707a4c96829063536f81cc10e144652102da1e7e Fixes #21348 Co-authored-by: Richard Levasseur <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A regression from upgrading to rules_python 0.22.0 is that a Python toolchain is no longer registered by default (the prior 0.4.0 version registered the "autodetecting" toolchain). Subsequent versions of rules_python (0.23.0 or later) register a toolchain by default again, but it's a downloaded runtime, which makes upgrading more involved.
To fix, upgrade to 0.22.1, which registers the autodetecting toolchain. This restores the rules_python 0.4.0 behavior and should suffice until bazel_tools is upgraded to 0.23.0 or later.