Skip to content

Read authentication information from .netrc#20417

Closed
guw wants to merge 5 commits intobazelbuild:masterfrom
guw:patch-1
Closed

Read authentication information from .netrc#20417
guw wants to merge 5 commits intobazelbuild:masterfrom
guw:patch-1

Conversation

@guw
Copy link
Copy Markdown
Contributor

@guw guw commented Dec 2, 2023

Workaround for #13709

@github-actions github-actions Bot added the awaiting-review PR is awaiting review from an assigned reviewer label Dec 2, 2023
fmeum
fmeum reviewed Dec 2, 2023
View reviewed changes
Comment thread tools/build_defs/repo/jvm.bzl Outdated
@sgowroji sgowroji added awaiting-user-response Awaiting a response from the author team-ExternalDeps External dependency handling, remote repositiories, WORKSPACE file. and removed awaiting-review PR is awaiting review from an assigned reviewer labels Dec 4, 2023
@meteorcloudy
Copy link
Copy Markdown
Member

meteorcloudy commented Dec 4, 2023

We are using http_archive directly from the bazel repo at

bazel/repositories.bzl

Line 19 in bb5ff63

load("//tools/build_defs/repo:http.bzl", "http_archive", "http_file")
instead of from @bazel_tools.

So the lockfile has to be updated.

@guw
Copy link
Copy Markdown
Contributor Author

guw commented Dec 4, 2023

So the lockfile has to be updated.

Should I do this in this PR?
Are there instructions?

@meteorcloudy
Copy link
Copy Markdown
Member

meteorcloudy commented Dec 4, 2023

Please run bazel mod deps --lockfile_mode=update to update your lockfile.

Just follow the error message. You probably also need to run

bazel/src/MODULE.tools

Lines 1 to 3 in dc70655

# NOTE: When editing this file, also update the lockfile.
# bazel run //src/test/tools/bzlmod:update_default_lock_file
# bazel mod deps --lockfile_mode=update

@guw
Copy link
Copy Markdown
Contributor Author

guw commented Dec 4, 2023

Updated the lock files. Can someone review if this is good?

@meteorcloudy
Copy link
Copy Markdown
Member

meteorcloudy commented Dec 5, 2023

The lockfile changes should be good. But can you check the test failure?

https://storage.googleapis.com/bazel-untrusted-buildkite-artifacts/018c3658-6f74-40ff-b908-b0b49b7c0687/src/test/shell/bazel/external_integration_test/shard_9_of_15/test_attempts/attempt_2.log

ERROR: Evaluation of query "deps(//zoo:ball-pit)" failed: preloading transitive closure failed: no such package '@@endangered//jar': No such attribute 'netrc'

@guw guw force-pushed the patch-1 branch 2 times, most recently from 8c81948 to 60018d7 Compare December 5, 2023 16:24
@guw guw requested a review from fmeum December 5, 2023 17:57
meteorcloudy
meteorcloudy approved these changes Dec 6, 2023
View reviewed changes
Copy link
Copy Markdown
Member

@meteorcloudy meteorcloudy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@meteorcloudy meteorcloudy added awaiting-PR-merge PR has been approved by a reviewer and is ready to be merge internally and removed awaiting-user-response Awaiting a response from the author labels Dec 6, 2023
@brentleyjones
Copy link
Copy Markdown
Contributor

brentleyjones commented Dec 6, 2023

@bazel-io flag

@bazel-io bazel-io added the potential release blocker Flagged by community members using "@bazel-io flag". Should be added to a release blocker milestone label Dec 6, 2023
@iancha1992
Copy link
Copy Markdown
Member

iancha1992 commented Dec 6, 2023

@bazel-io fork 7.1.0

@bazel-io bazel-io mentioned this pull request Dec 6, 2023
Closed
@bazel-io bazel-io removed the potential release blocker Flagged by community members using "@bazel-io flag". Should be added to a release blocker milestone label Dec 6, 2023
@copybara-service copybara-service Bot closed this in ce8bd90 Dec 7, 2023
@github-actions github-actions Bot removed the awaiting-PR-merge PR has been approved by a reviewer and is ready to be merge internally label Dec 7, 2023
@keertk keertk mentioned this pull request Jan 17, 2024
Merged
github-merge-queue Bot pushed a commit that referenced this pull request Jan 17, 2024
@keertk @guw
[7.1.0] Read authentication information from .netrc (#20915)
1821a88 
Workaround for #13709

Closes #20417.
Commit
ce8bd90

PiperOrigin-RevId: 588762567
Change-Id: Ie02d7ff6ffaad646bf67059bebc7e0d5894f079e

Co-authored-by: Gunnar Wagenknecht <[email protected]>
@iancha1992
Copy link
Copy Markdown
Member

iancha1992 commented Feb 23, 2024

The changes in this PR have been included in Bazel 7.1.0 RC1. Please test out the release candidate and report any issues as soon as possible. If you're using Bazelisk, you can point to the latest RC by setting USE_BAZEL_VERSION=last_rc.
Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@meteorcloudy meteorcloudy meteorcloudy approved these changes

+1 more reviewer

@fmeum fmeum fmeum approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

team-ExternalDeps External dependency handling, remote repositiories, WORKSPACE file.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

@guw @meteorcloudy @brentleyjones @iancha1992 @fmeum @bazel-io @sgowroji