Skip to content

[7.0.0] Generalize memory and cpu tracking #20396

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
iancha1992 merged 1 commit into from
Nov 30, 2023
Merged

[7.0.0] Generalize memory and cpu tracking #20396

iancha1992 merged 1 commit into from
Nov 30, 2023

Conversation

@iancha1992
Copy link
Member

@iancha1992 iancha1992 commented Nov 30, 2023

Remove special handling of cpu and memory, and instead track them as any other resource. This has a few advantages:

  • Significant code clean up, keep only the logic for generic resource around
  • Consistent resources type (double) for all resource

Relates to #19679

Closes #19839.

Commit ebe4d0d

PiperOrigin-RevId: 585926931
Change-Id: Id0d6a14e9c151c3895f55d1808b6bd66eecf98b3

@AlessandroPatti @iancha1992
Generalize memory and cpu tracking
f5246f7 
Remove special handling of cpu and memory, and instead track them as any other resource. This has a few advantages:
  - Significant code clean up, keep only the logic for generic resource around
  - Consistent resources type (double) for all resource

Relates to bazelbuild#19679

Closes bazelbuild#19839.

PiperOrigin-RevId: 585926931
Change-Id: Id0d6a14e9c151c3895f55d1808b6bd66eecf98b3
@iancha1992 iancha1992 added team-Performance Issues for Performance teams team-Configurability platforms, toolchains, cquery, select(), config transitions team-Local-Exec Issues and PRs for the Execution (Local) team awaiting-review PR is awaiting review from an assigned reviewer labels Nov 30, 2023
@iancha1992 iancha1992 requested a review from a team as a code owner November 30, 2023 18:21
@iancha1992 iancha1992 enabled auto-merge (squash) November 30, 2023 18:21
@github-actions github-actions bot added team-Rules-CPP Issues for C++ rules team-Rules-Java Issues for Java rules labels Nov 30, 2023
@iancha1992 iancha1992 mentioned this pull request Nov 30, 2023
Closed
@keertk keertk removed team-Configurability platforms, toolchains, cquery, select(), config transitions team-Rules-Java Issues for Java rules team-Rules-CPP Issues for C++ rules team-Local-Exec Issues and PRs for the Execution (Local) team labels Nov 30, 2023
@iancha1992 iancha1992 merged commit 0725711 into bazelbuild:release-7.0.0 Nov 30, 2023
@github-actions github-actions bot removed the awaiting-review PR is awaiting review from an assigned reviewer label Nov 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Wyverald Wyverald Wyverald approved these changes

@zhengwei143 zhengwei143 Awaiting requested review from zhengwei143

Assignees

No one assigned

Labels

team-Performance Issues for Performance teams

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@iancha1992 @Wyverald @keertk @AlessandroPatti