Fix typo in repo overrides for darwin_arm64 Java tools in tests#20374
Closed
fmeum wants to merge 1 commit intobazelbuild:masterfrom
Closed
Fix typo in repo overrides for darwin_arm64 Java tools in tests#20374fmeum wants to merge 1 commit intobazelbuild:masterfrom
fmeum wants to merge 1 commit intobazelbuild:masterfrom
Conversation
github-actions
Bot
added
the
awaiting-review
hvadehra
requested changes
Nov 30, 2023
fmeum
force-pushed
the
fix-java-tools-override-darwin-amd64
branch
from
f2fb510 to
d47903e
Compare
fmeum
changed the title
hvadehra
approved these changes
Nov 30, 2023
github-actions
Bot
removed
the
awaiting-review
copybara-service Bot
pushed a commit
that referenced
this pull request
Feb 16, 2024
…ting that overriding actually works Should help avoid issues like: #21351 #20374 #20294 (comment) Closes #21364. PiperOrigin-RevId: 607785065 Change-Id: Ib8c75d597911034091c3dafd638acfe72d2eb9c5
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See bazelbuild/java_tools#86 (comment)