Skip to content

[7.0.0] Remove RunfilesSupplier.getManifest(). #20357

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
iancha1992 merged 1 commit into from
Nov 29, 2023
Merged

[7.0.0] Remove RunfilesSupplier.getManifest(). #20357

iancha1992 merged 1 commit into from
Nov 29, 2023

Conversation

@tjgq
Copy link
Contributor

@tjgq tjgq commented Nov 29, 2023

It appears to be always empty.

RELNOTES: None.
PiperOrigin-RevId: 585627763
Change-Id: I7f39896c7f3a4ffb1040211265793b7f64d8d64d

@lberki @tjgq
[7.0.0] Remove RunfilesSupplier.getManifest().
13b8ae4 
It appears to be always empty.

RELNOTES: None.
PiperOrigin-RevId: 585627763
Change-Id: I7f39896c7f3a4ffb1040211265793b7f64d8d64d
@tjgq tjgq requested a review from a team as a code owner November 29, 2023 13:19
@github-actions github-actions bot added awaiting-review PR is awaiting review from an assigned reviewer team-Configurability platforms, toolchains, cquery, select(), config transitions team-Performance Issues for Performance teams team-Remote-Exec Issues and PRs for the Execution (Remote) team team-Rules-CPP Issues for C++ rules team-Rules-Java Issues for Java rules team-Rules-Python Native rules for Python labels Nov 29, 2023
@tjgq tjgq added this to the 7.0.0 release blockers milestone Nov 29, 2023
@iancha1992 iancha1992 enabled auto-merge (squash) November 29, 2023 13:53
@iancha1992 iancha1992 merged commit 2b700b5 into bazelbuild:release-7.0.0 Nov 29, 2023
@github-actions github-actions bot removed the awaiting-review PR is awaiting review from an assigned reviewer label Nov 29, 2023
bozaro pushed a commit to joomcode/bazel that referenced this pull request Jan 10, 2024
@tjgq @lberki @bozaro
[7.0.0] Remove RunfilesSupplier.getManifest(). (bazelbuild#20357)
663beb6 
It appears to be always empty.

RELNOTES: None.
PiperOrigin-RevId: 585627763
Change-Id: I7f39896c7f3a4ffb1040211265793b7f64d8d64d

Co-authored-by: Googler <[email protected]>
@tjgq tjgq deleted the getmanifest-cherrypick branch March 7, 2024 10:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@iancha1992 iancha1992 iancha1992 approved these changes

Assignees

No one assigned

Labels

team-Configurability platforms, toolchains, cquery, select(), config transitions team-Performance Issues for Performance teams team-Remote-Exec Issues and PRs for the Execution (Remote) team team-Rules-CPP Issues for C++ rules team-Rules-Java Issues for Java rules team-Rules-Python Native rules for Python

Projects

None yet

Milestone

7.0.0 release blockers

Development

Successfully merging this pull request may close these issues.

3 participants

@tjgq @iancha1992 @lberki