[7.0.0] Pass ct.sym to direct version of Turbine#20341
Merged
meteorcloudy merged 1 commit intobazelbuild:release-7.0.0from Nov 28, 2023
Merged
[7.0.0] Pass ct.sym to direct version of Turbine#20341meteorcloudy merged 1 commit intobazelbuild:release-7.0.0from
ct.sym to direct version of Turbine#20341meteorcloudy merged 1 commit intobazelbuild:release-7.0.0from
Conversation
Cherry-picked from 4a29f08 Compared to the cherry-picked commit, this does not contain the turbine update as turbine is not embedded into the Bazel binary and can be updated independently via rules_java. Original description follows: This ensures that Turbine has access to `ct.sym` and thus supports the `--release` flag even if it is compiled into a Graal native image, which doesn't have access to a `JAVA_HOME`. This requires exposing the `ct.sym` file on a new `lib_ct_sym` attribute of `java_runtime` and passing it into Turbine via the `turbine.ctSymPath` system property introduced in v0.3.1. Along the way this commit fixes the setup code for testing unreleased versions of the remote Java and coverage tools, which silently broke with the flip of `--enable_bzlmod`. Work towards bazelbuild/stardoc#195 Closes bazelbuild#20294. PiperOrigin-RevId: 585866870 Change-Id: I416b787e324bd3a01e223edbda4f9ba137c21241
github-actions
Bot
added
awaiting-review
Collaborator
Author
Member
|
Sorry, I was told the turbine change didn't make it into Bazel 7, do we still need this change? |
Member
|
Should we wait for 7.1.0? |
Member
|
Oh, just saw #20323 (comment) |
meteorcloudy
approved these changes
Nov 28, 2023
github-actions
Bot
removed
the
awaiting-review
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Cherry-picked from 4a29f08
Compared to the cherry-picked commit, this does not contain the turbine update as turbine is not embedded into the Bazel binary and can be updated independently via rules_java.
Original description follows:
This ensures that Turbine has access to
ct.symand thus supports the--releaseflag even if it is compiled into a Graal native image, which doesn't have access to aJAVA_HOME.This requires exposing the
ct.symfile on a newlib_ct_symattribute ofjava_runtimeand passing it into Turbine via theturbine.ctSymPathsystem property introduced in v0.3.1.Along the way this commit fixes the setup code for testing unreleased versions of the remote Java and coverage tools, which silently broke with the flip of
--enable_bzlmod.Work towards bazelbuild/stardoc#195
Closes #20294.
PiperOrigin-RevId: 585866870
Change-Id: I416b787e324bd3a01e223edbda4f9ba137c21241
Closes #20323