Skip to content

Conversation

@keertk
Copy link
Member

@keertk keertk commented Nov 9, 2023

By upgrading the Apache Commons Compress library to 1.20. I'm deliberately not upgrading to the most recent one (1.24.0) because it would require an additional JDK module (java.desktop) and significantly regress the binary size.

Fixes #20090.

Closes #20110.

Commit 93729f4

PiperOrigin-RevId: 580935354
Change-Id: I6c9728ac3fd925432f44a55efaef8f5b52d428c0

By upgrading the Apache Commons Compress library to 1.20. I'm
deliberately not upgrading to the most recent one (1.24.0)
because it would require an additional JDK module (java.desktop)
and significantly regress the binary size.

Fixes #20090.

Closes #20110.

PiperOrigin-RevId: 580935354
Change-Id: I6c9728ac3fd925432f44a55efaef8f5b52d428c0
@keertk keertk requested a review from a team as a code owner November 9, 2023 18:58
@keertk keertk added team-OSS Issues for the Bazel OSS team: installation, release processBazel packaging, website awaiting-review PR is awaiting review from an assigned reviewer labels Nov 9, 2023
@keertk keertk requested review from meteorcloudy and tjgq and removed request for a team November 9, 2023 18:59
@keertk
Copy link
Member Author

keertk commented Nov 9, 2023

@meteorcloudy @tjgq could you take a look at the failures please? I'm hesitant to run any of the suggested commands without context, but lmk if there's anything needed.

@tjgq
Copy link
Contributor

tjgq commented Nov 9, 2023

@keertk I believe you need to run REPIN=1 bazel run @unpinned_maven//:pin (to regen maven_install.json) followed by bazel mod deps (to regen MODULE.bazel.lock). If that doesn't work, please let me know here and I'll give it a try tomorrow morning.

@keertk
Copy link
Member Author

keertk commented Nov 9, 2023

Looks good now, thanks.

@keertk keertk requested a review from tjgq November 9, 2023 20:27
@keertk keertk enabled auto-merge (squash) November 9, 2023 20:27
@keertk keertk merged commit efe9b3c into release-7.0.0 Nov 9, 2023
@github-actions github-actions bot removed the awaiting-review PR is awaiting review from an assigned reviewer label Nov 9, 2023
@keertk keertk deleted the cp20110 branch November 9, 2023 20:31
@honwen
Copy link

honwen commented Nov 10, 2023

can u fix lts-6 as well?

@keertk
Copy link
Member Author

keertk commented Nov 10, 2023

@honwen we don't have plans for another 6.x release at the moment. We'll include this if we get more requests and go through with a release.

@keertk
Copy link
Member Author

keertk commented Dec 7, 2023

@bazel-io fork 6.5.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

team-OSS Issues for the Bazel OSS team: installation, release processBazel packaging, website

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants