Expose repo mapping manifest to Starlark#19944
Closed
fmeum wants to merge 1 commit intobazelbuild:masterfrom
Closed
Expose repo mapping manifest to Starlark#19944fmeum wants to merge 1 commit intobazelbuild:masterfrom
fmeum wants to merge 1 commit intobazelbuild:masterfrom
Conversation
The new `repo_mapping_manifest` field on `FilesToRunProvider` allows Starlark rule implementations to access the `File` containing the repo mapping manifest for an executable target, e.g. to include the manifest into a synthetic runfiles structure for packaging purposes.
fmeum
requested review from
aranguyen
and removed request for
a team and
aranguyen
github-actions
bot
added
awaiting-review
meteorcloudy
added
awaiting-PR-merge
|
Whoop whoop, can we cherry pick this to the 7.0.0 release so that it gets shipped in the next RC? |
Contributor
|
@bazel-io flag |
bazel-io
added
the
potential release blocker
Member
|
@bazel-io fork 7.0.0 |
bazel-io
removed
the
potential release blocker
github-actions
bot
removed
the
awaiting-PR-merge
bazel-io
pushed a commit
to bazel-io/bazel
that referenced
this pull request
Nov 2, 2023
The new `repo_mapping_manifest` field on `FilesToRunProvider` allows Starlark rule implementations to access the `File` containing the repo mapping manifest for an executable target, e.g. to include the manifest into a synthetic runfiles structure for packaging purposes. Fixes bazelbuild#19937 Closes bazelbuild#19944. PiperOrigin-RevId: 578735848 Change-Id: Ida78778af5aef4ba0c216815563aef4b54c9d1db
iancha1992
pushed a commit
that referenced
this pull request
Nov 2, 2023
The new `repo_mapping_manifest` field on `FilesToRunProvider` allows Starlark rule implementations to access the `File` containing the repo mapping manifest for an executable target, e.g. to include the manifest into a synthetic runfiles structure for packaging purposes. Fixes #19937 Closes #19944. Commit 3575211 PiperOrigin-RevId: 578735848 Change-Id: Ida78778af5aef4ba0c216815563aef4b54c9d1db Co-authored-by: Fabian Meumertzheim <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The new
repo_mapping_manifestfield onFilesToRunProviderallows Starlark rule implementations to access theFilecontaining the repo mapping manifest for an executable target, e.g. to include the manifest into a synthetic runfiles structure for packaging purposes.Fixes #19937