Skip to content

WIP: Flip --enable_bzlmod to true#19817

Closed
meteorcloudy wants to merge 1 commit intobazelbuild:masterfrom
meteorcloudy:flip_bzlmod
Closed

WIP: Flip --enable_bzlmod to true#19817
meteorcloudy wants to merge 1 commit intobazelbuild:masterfrom
meteorcloudy:flip_bzlmod

Conversation

@meteorcloudy
Copy link
Member

Bazel tests status:

  • AnalysisTestCase: Bzlmod disabled, to be migrated
  • ConfigurationTestCase: Bzlmod disabled, to be migrated
  • ConfigCommandTest: Bzlmod disabled, to be migrated, probably due to a bug
  • BuildViewTestCase: migrated at d51144c
  • BuildIntegrationTestCase: migrated in this change
  • Other Java unit tests migrated in this change
  • Java integration tests migrated at 8d04711
  • Shell integration tests migrated at 175a18d (Bzlmod disabled in some tests)
  • Python integration tests migrated at 50c8375 (Bzlmod disabled in some tests)

Issues identified:

  • cc_shared_library doesn't work well with Bzlmod: {issue link}
  • bazel config doesn't work well with Bzlmod: {issue link}

Fixes #18958

RELNOTES[INC]: Bzlmod is enabled by default, please consider migrating your external dependencies from WORKSPACE to MODULE.bazel. Find more details at #18958

PiperOrigin-RevId: 573218687
Change-Id: I097b4bd7caafc996b034284ee688b8f3d2bca1f7

Bazel tests status:

- AnalysisTestCase: Bzlmod disabled, to be migrated
- ConfigurationTestCase: Bzlmod disabled, to be migrated
- ConfigCommandTest: Bzlmod disabled, to be migrated, probably due to a bug
- BuildViewTestCase: migrated at bazelbuild@d51144c
- BuildIntegrationTestCase: migrated in this change
- Other Java unit tests migrated in this change
- Java integration tests migrated at bazelbuild@8d04711
- Shell integration tests migrated at bazelbuild@175a18d (Bzlmod disabled in some tests)
- Python integration tests migrated at bazelbuild@50c8375 (Bzlmod disabled in some tests)

Issues identified:

- cc_shared_library doesn't work well with Bzlmod: {issue link}
- `bazel config` doesn't work well with Bzlmod: {issue link}

Fixes bazelbuild#18958

RELNOTES[INC]: Bzlmod is enabled by default, please consider migrating your external dependencies from WORKSPACE to MODULE.bazel. Find more details at bazelbuild#18958

PiperOrigin-RevId: 573218687
Change-Id: I097b4bd7caafc996b034284ee688b8f3d2bca1f7
@meteorcloudy meteorcloudy requested review from a team and Wyverald as code owners October 14, 2023 20:37
@meteorcloudy meteorcloudy requested review from aiuto and removed request for a team October 14, 2023 20:37
@meteorcloudy meteorcloudy marked this pull request as draft October 14, 2023 20:37
@github-actions github-actions bot added awaiting-review PR is awaiting review from an assigned reviewer team-Configurability platforms, toolchains, cquery, select(), config transitions team-ExternalDeps External dependency handling, remote repositiories, WORKSPACE file. labels Oct 14, 2023
@meteorcloudy
Copy link
Member Author

@katre
Copy link
Collaborator

katre commented Oct 16, 2023

Please CC me on the bazel config issue and I'll take a look.

@github-actions github-actions bot removed the awaiting-review PR is awaiting review from an assigned reviewer label Oct 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

team-Configurability platforms, toolchains, cquery, select(), config transitions team-ExternalDeps External dependency handling, remote repositiories, WORKSPACE file.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

enable_bzlmod: Flip the default value of --enable_bzlmod to true

2 participants