Raise an early error on invalid labels in transitions inputs/outputs #19634
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
awaiting-review
fmeum
requested review from
a team,
Wyverald and
gregestren
and removed request for
a team,
aiuto,
gregestren and
lberki
fmeum
commented
Sep 26, 2023
src/test/java/com/google/devtools/build/lib/analysis/RunfilesRepoMappingManifestTest.java
Outdated
Show resolved
Hide resolved
fmeum
force-pushed
the
19632-transition-labels
branch
from
6136bed to
04bab27
Compare
Collaborator
Author
|
@bazel-io flag |
bazel-io
added
the
potential release blocker
Member
|
@bazel-io fork 6.4.0 |
bazel-io
removed
the
potential release blocker
Wyverald
reviewed
Sep 29, 2023
src/main/java/com/google/devtools/build/lib/rules/config/ConfigGlobalLibrary.java
Outdated
Show resolved
Hide resolved
Wyverald
approved these changes
Sep 29, 2023
Member
Wyverald
left a comment
Wyverald
left a comment
There was a problem hiding this comment.
please import after comments are addressed!
When a label pointing to an unavailable repository is specified as a transition's input or output, an early error is raised instead of crashing during transition evaluation.
fmeum
force-pushed
the
19632-transition-labels
branch
from
04bab27 to
5d597af
Compare
Collaborator
Author
|
@iancha1992 Comments resolved |
iancha1992
added
awaiting-PR-merge
github-actions
bot
removed
the
awaiting-PR-merge
fmeum
added a commit
to fmeum/bazel
that referenced
this pull request
Oct 9, 2023
When a label pointing to an unavailable repository is specified as a transition's input or output, an early error is raised instead of crashing during transition evaluation. Fixes bazelbuild#19632 Closes bazelbuild#19634. PiperOrigin-RevId: 570634319 Change-Id: Icda2946313898db2372484b4f845aafcf5a8b272
fmeum
added a commit
to fmeum/bazel
that referenced
this pull request
Oct 9, 2023
When a label pointing to an unavailable repository is specified as a transition's input or output, an early error is raised instead of crashing during transition evaluation. Fixes bazelbuild#19632 Closes bazelbuild#19634. PiperOrigin-RevId: 570634319 Change-Id: Icda2946313898db2372484b4f845aafcf5a8b272
meteorcloudy
pushed a commit
that referenced
this pull request
Oct 9, 2023
…19764) When a label pointing to an unavailable repository is specified as a transition's input or output, an early error is raised instead of crashing during transition evaluation. Fixes #19632 Closes #19634. PiperOrigin-RevId: 570634319 Change-Id: Icda2946313898db2372484b4f845aafcf5a8b272 Fixes #19641
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When a label pointing to an unavailable repository is specified as a transition's input or output, an early error is raised instead of crashing during transition evaluation.
Fixes #19632