Do not force linking of default link libs in Unix toolchain#19440
Closed
fmeum wants to merge 1 commit intobazelbuild:masterfrom
Closed
Do not force linking of default link libs in Unix toolchain#19440fmeum wants to merge 1 commit intobazelbuild:masterfrom
fmeum wants to merge 1 commit intobazelbuild:masterfrom
Conversation
`libstdc++` (`libc++` on macOS) and `libm` are no longer linked in if none of their symbols are referenced, e.g., in a pure C target.
fmeum
force-pushed
the
do-not-link-libstdcpp
branch
from
e51efee to
9727201
Compare
github-actions
Bot
added
awaiting-review
buildbreaker2021
approved these changes
Sep 7, 2023
buildbreaker2021
added
awaiting-PR-merge
github-actions
Bot
removed
the
awaiting-PR-merge
Contributor
|
Is there a similar change that needs to be made in the apple_support Xcode toolchain? |
Collaborator
Author
Not sure. I searched for |
Contributor
|
I do not know. Do you @keith? |
Member
|
nope, that toolchain never handled these libs |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
libstdc++(libc++on macOS) andlibmare no longer linked in if none of their symbols are referenced, e.g., in a pure C target.Fixes #6221