Ignore Starlark options on commands with allowResidue = False
#19363
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fmeum
force-pushed
the
allow-starlark-options-on-version
branch
from
83eb660 to
af95305
Compare
fmeum
changed the title
bazel versionallowResidue = False
Collaborator
Author
|
@haxorz Could you review this small follow-up to the |
justinhorvitz
approved these changes
Aug 30, 2023
Ensures that `bazel version` does not fail when a `common` line in `.bazelrc` contains a Starlark option (similar for `sync` and `shutdown`). There is very little chance for users being confused about these commands accepting and silently ignoring Starlark flags.
fmeum
force-pushed
the
allow-starlark-options-on-version
branch
from
af95305 to
915c13c
Compare
github-actions
bot
added
the
awaiting-review
iancha1992
added
the
team-Core
justinhorvitz
approved these changes
Aug 31, 2023
Member
|
Hi @justinhorvitz, Since I can see that this PR has been approved, please let me know whether I should proceed with importing it. |
Contributor
|
Yes it is ready to import, thanks. |
Collaborator
Author
|
@bazel-io flag |
bazel-io
added
the
potential release blocker
Member
|
@bazel-io fork 6.4.0 |
bazel-io
removed
the
potential release blocker
iancha1992
added
awaiting-PR-merge
github-actions
bot
removed
the
awaiting-PR-merge
bazel-io
pushed a commit
to bazel-io/bazel
that referenced
this pull request
Sep 6, 2023
Ensures that `bazel version` does not fail when a `common` line in `.bazelrc` contains a Starlark option (similar for `sync` and `shutdown`). There is very little chance for users being confused about these commands accepting and silently ignoring Starlark flags. Fixes bazelbuild#18130 (comment) Closes bazelbuild#19363. PiperOrigin-RevId: 562959337 Change-Id: Ifb4f44d63f1801f6c5a8c2f421138b4014c49a06
iancha1992
pushed a commit
that referenced
this pull request
Sep 6, 2023
…e` (#19417) Ensures that `bazel version` does not fail when a `common` line in `.bazelrc` contains a Starlark option (similar for `sync` and `shutdown`). There is very little chance for users being confused about these commands accepting and silently ignoring Starlark flags. Fixes #18130 (comment) Closes #19363. Commit 954b4d9 PiperOrigin-RevId: 562959337 Change-Id: Ifb4f44d63f1801f6c5a8c2f421138b4014c49a06 Co-authored-by: Fabian Meumertzheim <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ensures that
bazel versiondoes not fail when acommonline in.bazelrccontains a Starlark option (similar forsyncandshutdown). There is very little chance for users being confused about these commands accepting and silently ignoring Starlark flags.Fixes #18130 (comment)