Skip to content

Conversation

@NelsonLi0701
Copy link
Contributor

@NelsonLi0701 NelsonLi0701 commented Jul 27, 2023

Previously, Bazel only printed Failed methods in the detailed test summary when using the --test_summary=detailed option. With this change, both Passed and Failed methods are now printed, providing a more comprehensive view of the test results.

Fix #18685

RELNOTES: The --test_summary=detailed option now also prints passed test cases.

Previously, Bazel only printed Failed methods in the detailed test summary
when using the `--test_summary=detailed` option. With this change, both
Passed and Failed methods are now printed, providing a more comprehensive
view of the test results.

Fix bazelbuild#18685
@github-actions github-actions bot added the awaiting-review PR is awaiting review from an assigned reviewer label Jul 27, 2023
@Pavank1992 Pavank1992 added the team-Core Skyframe, bazel query, BEP, options parsing, bazelrc label Jul 27, 2023
Copy link
Member

@jin jin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Previously, Bazel only printed Failed methods in the detailed test summary
when using the `--test_summary=detailed` option. With this change, both
Passed and Failed methods are now printed, providing a more comprehensive
view of the test results.

Fix bazelbuild#18685
@NelsonLi0701 NelsonLi0701 force-pushed the print_passed_methods branch from dfda50c to 3dc1e81 Compare July 28, 2023 07:44
@NelsonLi0701
Copy link
Contributor Author

Please also add an integration test like this: https://cs.opensource.google/bazel/bazel/+/master:src/test/shell/bazel/bazel_test_test.sh;l=652-663;drc=ecf9b9a82aa231cd1fa9178dd9ab64dd67adaf25

Added test_detailed_test_summary_for_passed_test and rename the original test_detailed_test_summary to test_detailed_test_summary_for_failed_test

@jin jin added awaiting-PR-merge PR has been approved by a reviewer and is ready to be merge internally and removed awaiting-review PR is awaiting review from an assigned reviewer labels Jul 28, 2023
@jin
Copy link
Member

jin commented Jul 28, 2023

According to Bazel PR import instructions, I'll let the gTech team handle the PR import.

NelsonLi0701 and others added 9 commits August 2, 2023 01:51
Previously, Bazel only printed Failed methods in the detailed test summary
when using the `--test_summary=detailed` option. With this change, both
Passed and Failed methods are now printed, providing a more comprehensive
view of the test results.

Fix bazelbuild#18685
Previously, Bazel only printed Failed methods in the detailed test summary
when using the `--test_summary=detailed` option. With this change, both
Passed and Failed methods are now printed, providing a more comprehensive
view of the test results.

Fix bazelbuild#18685
Previously, Bazel only printed Failed methods in the detailed test summary
when using the `--test_summary=detailed` option. With this change, both
Passed and Failed methods are now printed, providing a more comprehensive
view of the test results.

Fix bazelbuild#18685
Previously, Bazel only printed Failed methods in the detailed test summary
when using the `--test_summary=detailed` option. With this change, both
Passed and Failed methods are now printed, providing a more comprehensive
view of the test results.

Fix bazelbuild#18685
@copybara-service copybara-service bot closed this in c75fda9 Aug 4, 2023
@github-actions github-actions bot removed the awaiting-PR-merge PR has been approved by a reviewer and is ready to be merge internally label Aug 4, 2023
@jin
Copy link
Member

jin commented Aug 4, 2023

Congrats on your first PR to Bazel, Nelson!

thirtyseven pushed a commit to thirtyseven/bazel that referenced this pull request Sep 13, 2023
Previously, Bazel only printed Failed methods in the detailed test summary when using the `--test_summary=detailed` option. With this change, both Passed and Failed methods are now printed, providing a more comprehensive view of the test results.

Fix bazelbuild#18685

Closes bazelbuild#19099.

RELNOTES:  The `--test_summary=detailed` option now also prints passed test cases.
PiperOrigin-RevId: 553737487
Change-Id: I332b70d916394de7caed7a07667b46087724a6c1
iancha1992 pushed a commit that referenced this pull request Sep 13, 2023
)

Cherry-pick of c75fda9

Previously, Bazel only printed Failed methods in the detailed test
summary when using the `--test_summary=detailed` option. With this
change, both Passed and Failed methods are now printed, providing a more
comprehensive view of the test results.

Fix #18685

Closes #19099.

RELNOTES: The `--test_summary=detailed` option now also prints passed
test cases.
PiperOrigin-RevId: 553737487
Change-Id: I332b70d916394de7caed7a07667b46087724a6c1

Co-authored-by: NelsonLi0701 <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

team-Core Skyframe, bazel query, BEP, options parsing, bazelrc

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Print successful test methods when running bazel test --test_summary=detailed

3 participants