Identify isolated extensions by exported name #18840
Conversation
|
Stacked on #18829 |
github-actions
bot
added
awaiting-review
fmeum
force-pushed
the
isolate-by-exported-name
branch
from
734471e to
2ccd108
Compare
Instead of making a running counter and the `dev_dependency` bit the identifier of an isolated module extension usage within a module file, use the exported name of the usage. This still results in a stable name even with `--ignore_dev_dependency` flips, but makes the canonical repository name more recognizable and allows for less verbose buildozer fixup commands.
fmeum
force-pushed
the
isolate-by-exported-name
branch
from
2ccd108 to
3a8437a
Compare
|
@Wyverald I rebased onto master. |
|
@bazel-io flag |
bazel-io
added
the
potential release blocker
Wyverald
added
awaiting-PR-merge
|
@bazel-io fork 6.3.0 |
bazel-io
removed
the
potential release blocker
github-actions
bot
removed
the
awaiting-PR-merge
|
@fmeum @Wyverald looks like there's a conflict when attemting a cherry-pick to release-6.3.0. from the "src/main/java/com/google/devtools/build/lib/bazel/bzlmod/BazelDepGraphFunction.java" "bestName" variable should not be: Instead, should be somewhat looks like below before the cherry-pick:
Can you please take a look and let us know which commit to push in order to resolve this? Thanks! cc: @bazelbuild/triage |
|
It's safe to just use the longer snippet you pasted. |
Instead of making a running counter and the `dev_dependency` bit the identifier of an isolated module extension usage within a module file, use the exported name of the usage. This still results in a stable name even with `--ignore_dev_dependency` flips, but makes the canonical repository name more recognizable and allows for less verbose buildozer fixup commands. Closes bazelbuild#18840. PiperOrigin-RevId: 547587673 Change-Id: I2137ed83f1600c00f73539c8a3f002268e4c0476
Instead of making a running counter and the `dev_dependency` bit the identifier of an isolated module extension usage within a module file, use the exported name of the usage. This still results in a stable name even with `--ignore_dev_dependency` flips, but makes the canonical repository name more recognizable and allows for less verbose buildozer fixup commands. Closes bazelbuild#18840. PiperOrigin-RevId: 547587673 Change-Id: I2137ed83f1600c00f73539c8a3f002268e4c0476
|
@fmeum @Wyverald we're not able to get this into rc1 (to go out shortly) unfortunately - there are still some failures in #18923. Please let us know if this cherry-pick is required and we can create another release candidate in the coming days. Thanks! Edit: pushed RC1 to 7/13, so we still have a day to get this in if needed. |
|
See #18923 (comment), a previous cherry-pick ended up partially reverting an earlier one. |
Instead of making a running counter and the `dev_dependency` bit the identifier of an isolated module extension usage within a module file, use the exported name of the usage. This still results in a stable name even with `--ignore_dev_dependency` flips, but makes the canonical repository name more recognizable and allows for less verbose buildozer fixup commands. Closes #18840. PiperOrigin-RevId: 547587673 Change-Id: I2137ed83f1600c00f73539c8a3f002268e4c0476 Co-authored-by: Fabian Meumertzheim <[email protected]>
5 participants
Instead of making a running counter and the
dev_dependencybit theidentifier of an isolated module extension usage within a module file,
use the exported name of the usage. This still results in a stable name
even with
--ignore_dev_dependencyflips, but makes the canonicalrepository name more recognizable and allows for less verbose buildozer
fixup commands.