Fix OOM in describeNestedSetFingerprint
#18678
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`describedNestedSetFingerprint` appended a `StringBuilder` to itself in a loop instead of the actual item from the nested set, resulting in OOMs in `Runfiles#describeKey` and `RepoMappingManifestAction#describeKey`. Work towards bazelbuild#18666 Closes bazelbuild#18668. PiperOrigin-RevId: 540270874 Change-Id: Id408ab4c2438bea264b586f8ae5567dc41260242
iancha1992
added
team-ExternalDeps
Member
Author
Member
Author
@fmeum @lberki actually I think it's failing because the change includes the function: public static String describedNestedSetFingerprint, which is missing in the release-6.3.0 branch. Is there a PR or commit that you know of that has that function? I'd be glad to push it to the branch so that we can cherry-pick this one to release-6.3.0. |
auto-merge was automatically disabled
June 15, 2023 18:34
Pull request was closed
Collaborator
|
@iancha1992 it's missing #18384 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
describedNestedSetFingerprintappended aStringBuilderto itself in a loop instead of the actual item from the nested set, resulting in OOMs inRunfiles#describeKeyandRepoMappingManifestAction#describeKey.Work towards #18666
Closes #18668.
Commit a6a874b
PiperOrigin-RevId: 540270874
Change-Id: Id408ab4c2438bea264b586f8ae5567dc41260242