Fix OOM in describeNestedSetFingerprint
#18668
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`describedNestedSetFingerprint` appended a `StringBuilder` to itself in a loop instead of the actual item from the nested set.
github-actions
bot
added
the
awaiting-review
Collaborator
Author
|
@bazel-io flag |
bazel-io
added
the
potential release blocker
fmeum
changed the title
Runfiles#describeKeydescribeNestedSetFingerprint
Collaborator
Author
|
CC @Wyverald |
lberki
approved these changes
Jun 14, 2023
Contributor
lberki
left a comment
lberki
left a comment
There was a problem hiding this comment.
Thanks for the fix! This is somewhat embarrassing.
lberki
added
awaiting-PR-merge
Member
|
@bazel-io fork 6.3.0 |
bazel-io
removed
the
potential release blocker
iancha1992
added
team-ExternalDeps
iancha1992
pushed a commit
to iancha1992/bazel
that referenced
this pull request
Jun 14, 2023
`describedNestedSetFingerprint` appended a `StringBuilder` to itself in a loop instead of the actual item from the nested set, resulting in OOMs in `Runfiles#describeKey` and `RepoMappingManifestAction#describeKey`. Work towards bazelbuild#18666 Closes bazelbuild#18668. PiperOrigin-RevId: 540270874 Change-Id: Id408ab4c2438bea264b586f8ae5567dc41260242
traversaro
pushed a commit
to traversaro/bazel
that referenced
this pull request
Jun 24, 2023
`describedNestedSetFingerprint` appended a `StringBuilder` to itself in a loop instead of the actual item from the nested set, resulting in OOMs in `Runfiles#describeKey` and `RepoMappingManifestAction#describeKey`. Work towards bazelbuild#18666 Closes bazelbuild#18668. PiperOrigin-RevId: 540270874 Change-Id: Id408ab4c2438bea264b586f8ae5567dc41260242
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
describedNestedSetFingerprintappended aStringBuilderto itself in a loop instead of the actual item from the nested set, resulting in OOMs inRunfiles#describeKeyandRepoMappingManifestAction#describeKey.Work towards #18666