Skip to content

Conversation

@tjgq
Copy link
Contributor

@tjgq tjgq commented Jun 8, 2023

No description provided.

@tjgq tjgq marked this pull request as ready for review June 11, 2023 10:44
@tjgq tjgq requested review from a team, Wyverald and meteorcloudy as code owners June 11, 2023 10:44
@github-actions github-actions bot added awaiting-review PR is awaiting review from an assigned reviewer team-ExternalDeps External dependency handling, remote repositiories, WORKSPACE file. team-Remote-Exec Issues and PRs for the Execution (Remote) team labels Jun 11, 2023
@tjgq
Copy link
Contributor Author

tjgq commented Jun 11, 2023

@Yannic I think we're ready to declare credential helpers to be stable. Please let me know if you have any remaining concerns!

Copy link
Member

@coeuvre coeuvre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great!

Copy link
Member

@meteorcloudy meteorcloudy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉 Do we need to backport this (and maybe other changes) to 6.3.0?

Copy link
Contributor

@Yannic Yannic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's do it!

@tjgq
Copy link
Contributor Author

tjgq commented Jun 12, 2023

@bazel-io fork 6.3.0

@iancha1992
Copy link
Member

@bazel-io fork 6.3.0

iancha1992 pushed a commit to iancha1992/bazel that referenced this pull request Jun 22, 2023
Closes bazelbuild#18615.

PiperOrigin-RevId: 539607278
Change-Id: I250250452db923ba132f1445c46b0112b175e505
@iancha1992 iancha1992 removed the awaiting-review PR is awaiting review from an assigned reviewer label Jun 22, 2023
iancha1992 added a commit that referenced this pull request Jun 23, 2023
Closes #18615.

PiperOrigin-RevId: 539607278
Change-Id: I250250452db923ba132f1445c46b0112b175e505

Co-authored-by: Tiago Quelhas <[email protected]>
traversaro pushed a commit to traversaro/bazel that referenced this pull request Jun 24, 2023
Closes bazelbuild#18615.

PiperOrigin-RevId: 539607278
Change-Id: I250250452db923ba132f1445c46b0112b175e505
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

team-ExternalDeps External dependency handling, remote repositiories, WORKSPACE file. team-Remote-Exec Issues and PRs for the Execution (Remote) team

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants