Don't rewind the build if invocation id stays the same #18591
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
awaiting-review
Member
Author
|
@bazel-io fork 6.3.0 |
Member
|
@coeuvre looks like we'll need another commit before we cherry-pick this to 6.3.0 because function test_download_toplevel_symlinks_runfiles() and function test_download_toplevel_root_symlinks_runfiles() should have been in the release-6.3.0 before we cherry-pick this commit. |
coeuvre
added a commit
to coeuvre/bazel
that referenced
this pull request
Jun 14, 2023
Invocation id (`BUILD_ID` in code) is expected to be different for each command. When retrying the build, we rely on Bazel generating a new invocation id for a new attempt. However, if flag `--invocation_id` is set, Bazel just uses the provided value instead of generating a new one. In this case, invocation id stays the same among multiple attempts which could cause issues like bazelbuild#18547. This PR fixes that by not retrying the build if the invocation id is same to previous attempt. Also updated the doc to point this requirement out. Closes bazelbuild#18591. PiperOrigin-RevId: 539946840 Change-Id: I6ae85ea923b0fdbff97fe2e44e36995f0205f8a1
Member
Author
|
It's fine to ignore (remove) them because they are irrelevant to this change. I have created #18670. |
iancha1992
pushed a commit
that referenced
this pull request
Jun 14, 2023
Invocation id (`BUILD_ID` in code) is expected to be different for each command. When retrying the build, we rely on Bazel generating a new invocation id for a new attempt. However, if flag `--invocation_id` is set, Bazel just uses the provided value instead of generating a new one. In this case, invocation id stays the same among multiple attempts which could cause issues like #18547. This PR fixes that by not retrying the build if the invocation id is same to previous attempt. Also updated the doc to point this requirement out. Closes #18591. PiperOrigin-RevId: 539946840 Change-Id: I6ae85ea923b0fdbff97fe2e44e36995f0205f8a1
iancha1992
removed
the
awaiting-review
traversaro
pushed a commit
to traversaro/bazel
that referenced
this pull request
Jun 24, 2023
Invocation id (`BUILD_ID` in code) is expected to be different for each command. When retrying the build, we rely on Bazel generating a new invocation id for a new attempt. However, if flag `--invocation_id` is set, Bazel just uses the provided value instead of generating a new one. In this case, invocation id stays the same among multiple attempts which could cause issues like bazelbuild#18547. This PR fixes that by not retrying the build if the invocation id is same to previous attempt. Also updated the doc to point this requirement out. Closes bazelbuild#18591. PiperOrigin-RevId: 539946840 Change-Id: I6ae85ea923b0fdbff97fe2e44e36995f0205f8a1
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Invocation id (
BUILD_IDin code) is expected to be different for each command. When retrying the build, we rely on Bazel generating a new invocation id for a new attempt. However, if flag--invocation_idis set, Bazel just uses the provided value instead of generating a new one. In this case, invocation id stays the same among multiple attempts which could cause issues like #18547.This PR fixes that by not retrying the build if the invocation id is same to previous attempt. Also updated the doc to point this requirement out.