Fix https://github.com/bazelbuild/bazel/issues/18493. #18509
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pavank1992
added
the
team-OSS
Pavank1992
added
the
awaiting-review
meteorcloudy
requested changes
May 26, 2023
| echo "$output" | grep --fixed-strings 'ExecuteProgram(C:\first_part second_part)' || fail "Expected error message to contain unquoted path" | ||
| } | ||
|
|
||
| function test_run_with_runfiles_env() { |
Member
There was a problem hiding this comment.
This test case is not in the original PR: https://github.com/bazelbuild/bazel/pull/18498/files
Did you have to deal with some merge conflict? Let's remove this one since it's unrelated.
Member
|
Created this one instead: #18512 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The use of the pipe in
b8e92cc made it swallow the exit code, so we need to set pipefail.
Fix #18493
Closes #18498.
PiperOrigin-RevId: 535520323
Change-Id: Idf1a5c39bf5b7deec29b76c10ece2825b568ebf2