[6.3.0] Let common ignore unsupported options
#18507
Conversation
Fixes bazelbuild#3054 RELNOTES: Options specified on the pseudo-command `common` in `.rc` files are now ignored by commands that do not support them as long as they are valid options for *any* Bazel command. Previously, commands that did not support all options given for `common` would fail to run. These previous semantics of `common` are now available via the new `always` pseudo-command. Closes bazelbuild#18130. PiperOrigin-RevId: 534940403 Change-Id: I2ae268ae84de3f2b07ff3d1e36bf382bce714968
|
@fmeum When I tried to cherry-pick the commit (see 44d3953 ), I did get some merge conflicts. But all of them were good except for the file at src/test/java/com/google/devtools/common/options/OptionsParserTest.java. I'm thinking that there was a previous commit that introduced those two functions. However, I did remove those two functions so that all the conflicts found in this PR mirror the ones from the original commit 44d3953. Please feel free to make changes directly if needed regarding those functions. |
|
@iancha1992 The conflict is from #16563, which is small and also lends itself to being cherry-picked. |
Pavank1992
added
team-Core
iancha1992
removed
team-Core
|
Close as this is a duplicate PR for: #18566 |
3 participants
Fixes #3054
RELNOTES: Options specified on the pseudo-command
commonin.rcfiles are now ignored by commands that do not support them as long as they are valid options for any Bazel command. Previously, commands that did not support all options given forcommonwould fail to run. These previous semantics ofcommonare now available via the newalwayspseudo-command.Closes #18130.
Commit 44d3953
PiperOrigin-RevId: 534940403
Change-Id: I2ae268ae84de3f2b07ff3d1e36bf382bce714968