Fix https://github.com/bazelbuild/bazel/issues/18493. #18498
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The use of the pipe in bazelbuild@b8e92cc made it swallow the exit code, so we need to set pipefail.
github-actions
bot
added
the
awaiting-review
sgowroji
added
the
team-OSS
meteorcloudy
approved these changes
May 25, 2023
Member
|
/cc @keertk @iancha1992 |
Member
|
@meteorcloudy / @meisterT is this PR ready to be imported? |
meteorcloudy
added
awaiting-PR-merge
Member
|
@keertk Yes, sorry for forgetting to apply the label. |
Pavank1992
removed
the
awaiting-PR-merge
Contributor
|
@bazel-io flag |
bazel-io
added
the
potential release blocker
Contributor
Member
|
The issue this PR trying to fix is already marked for cherry picking for 6.2.1 and 6.3.0 |
meteorcloudy
removed
the
potential release blocker
meteorcloudy
pushed a commit
that referenced
this pull request
May 26, 2023
meteorcloudy
pushed a commit
that referenced
this pull request
May 30, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The use of the pipe in
b8e92cc made it swallow the exit code, so we need to set pipefail.
Fix #18493