Skip to content

Upgrade absl-py from 0.1.1 to 1.3.0#18497

Closed
fweikert wants to merge 1 commit intobazelbuild:masterfrom
fweikert:absl2
Closed

Upgrade absl-py from 0.1.1 to 1.3.0#18497
fweikert wants to merge 1 commit intobazelbuild:masterfrom
fweikert:absl2

Conversation

@fweikert
Copy link
Copy Markdown
Member

@fweikert fweikert commented May 25, 2023

Should fix #16975

@github-actions github-actions Bot added the awaiting-review PR is awaiting review from an assigned reviewer label May 25, 2023
@sgowroji sgowroji added the team-ExternalDeps External dependency handling, remote repositiories, WORKSPACE file. label May 25, 2023
copybara-service Bot pushed a commit that referenced this pull request May 26, 2023
… Python 3.

This should fix the errors blocking #18497

PiperOrigin-RevId: 535582491
Change-Id: I92c37f74119caaccfc93f58c058ebb4cea56ad7c
copybara-service Bot pushed a commit that referenced this pull request Jun 26, 2023
These tests are incompatible with Python 3 environments.

This change unblocks #18497.
The tests should be fixed and re-enabled, tracked in #18776

PiperOrigin-RevId: 543491138
Change-Id: Id7faa248a7b57c3d645216bdba98c54534b06217
@fweikert fweikert force-pushed the absl2 branch 2 times, most recently from 61505e9 to ddd362d Compare June 26, 2023 19:18
@meteorcloudy
Copy link
Copy Markdown
Member

@meteorcloudy
Copy link
Copy Markdown
Member

I'm wondering maybe we should use rules_python to fetch those dependencies in the long term?

@fweikert
Copy link
Copy Markdown
Member Author

Yeah, I guess that's the long term plan.

@meteorcloudy
Copy link
Copy Markdown
Member

which means we have to split this PR to merge the changes..

@fweikert
Copy link
Copy Markdown
Member Author

Arg, I forgot :( will do

copybara-service Bot pushed a commit that referenced this pull request Jun 27, 2023
Required by #18497 which increases the size by ~10mb.

PiperOrigin-RevId: 543714205
Change-Id: I3aaacfca6f2c58cf41bb88b4cd07e269ede45515
@fweikert fweikert added awaiting-PR-merge PR has been approved by a reviewer and is ready to be merge internally and removed awaiting-review PR is awaiting review from an assigned reviewer labels Jun 27, 2023
copybara-service Bot pushed a commit that referenced this pull request Jun 27, 2023
Partial commit for third_party/*, see #18497.

Signed-off-by: fweikert <[email protected]>

Progress towards #16975
@fweikert fweikert removed the awaiting-PR-merge PR has been approved by a reviewer and is ready to be merge internally label Jun 27, 2023
@fweikert fweikert closed this Jun 27, 2023
copybara-service Bot pushed a commit that referenced this pull request Jun 27, 2023
This CL can be submitted once the Python version problem has been solved by #18497

Fixes #16975

PiperOrigin-RevId: 543742501
Change-Id: Ie4ff1c94f38030cf709bcf60ac5a91beadb9b13d
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

team-ExternalDeps External dependency handling, remote repositiories, WORKSPACE file.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

//scripts/docs:rewriter_test fails with Python 3.10

3 participants