Report percentual download progress in repository rules #18450
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If the HTTP response to a download request contains a `Content-Length` header, download progress is now reported as `10.1 MiB (20.2%)` instead of `10.1 MiB (10,590,000B)`.
fmeum
force-pushed
the
download-total-size
branch
from
6f83010 to
010e6d0
Compare
github-actions
bot
added
awaiting-review
meteorcloudy
added
awaiting-PR-merge
Collaborator
Author
|
@bazel-io flag |
bazel-io
added
the
potential release blocker
Collaborator
Author
|
@coeuvre Not something for this PR, but I wonder whether we should consolidate the different ways download progress is presented across repo and remote cache downloads at some point. I don't know what the best format would be, but we could track and discuss in an issue. |
Member
|
@bazel-io fork 6.3.0 |
bazel-io
removed
the
potential release blocker
Collaborator
Author
|
@meteorcloudy I pushed a small commit that handles edge cases I missed earlier. |
meteorcloudy
approved these changes
May 22, 2023
Member
Yes, I agree. Would you mind creating an issue for this? |
coeuvre
approved these changes
May 22, 2023
Pavank1992
removed
the
awaiting-PR-merge
iancha1992
pushed a commit
to iancha1992/bazel
that referenced
this pull request
May 22, 2023
If the HTTP response to a download request contains a `Content-Length` header, download progress is now reported as `10.1 MiB (20.2%)` instead of `10.1 MiB (10,590,000B)`. Closes bazelbuild#18450. PiperOrigin-RevId: 534035444 Change-Id: I1c5144555eda1890652b4d3f62b414292ba909d5
iancha1992
added a commit
that referenced
this pull request
May 23, 2023
If the HTTP response to a download request contains a `Content-Length` header, download progress is now reported as `10.1 MiB (20.2%)` instead of `10.1 MiB (10,590,000B)`. Closes #18450. PiperOrigin-RevId: 534035444 Change-Id: I1c5144555eda1890652b4d3f62b414292ba909d5 Co-authored-by: Fabian Meumertzheim <[email protected]>
fweikert
pushed a commit
to fweikert/bazel
that referenced
this pull request
May 25, 2023
If the HTTP response to a download request contains a `Content-Length` header, download progress is now reported as `10.1 MiB (20.2%)` instead of `10.1 MiB (10,590,000B)`. Closes bazelbuild#18450. PiperOrigin-RevId: 534035444 Change-Id: I1c5144555eda1890652b4d3f62b414292ba909d5
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If the HTTP response to a download request contains a
Content-Lengthheader, download progress is now reported as10.1 MiB (20.2%)instead of10.1 MiB (10,590,000B).