cc_library: propagate data dependencies via implementation_deps. #18416
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
awaiting-review
oquenchil
approved these changes
May 30, 2023
oquenchil
added
awaiting-PR-merge
Pavank1992
removed
the
awaiting-PR-merge
jlaxson
pushed a commit
to jlaxson/bazel
that referenced
this pull request
Sep 22, 2023
Sources from `implementation_deps` aren't propagated for compilation, but their runfiles may still be needed in runtime; they currently aren't provided, which seems like a bug (reproduction in [gist](https://gist.github.com/quval/2cc5b2cd323a10ae6a9375f326a296c2)). Closes bazelbuild#18416. PiperOrigin-RevId: 537010768 Change-Id: I76f95d6c59d79786febfb7a4ac7f9204fc194456
iancha1992
pushed a commit
that referenced
this pull request
Sep 25, 2023
…ps. (#19590) Cherry pick 56e9020 from #18416 Commit 56e9020 Co-authored-by: Yuval Kaplan <[email protected]>
Member
|
A fix for this issue has been included in Bazel 6.4.0 RC2. Please test out the release candidate and report any issues as soon as possible. Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sources from
implementation_depsaren't propagated for compilation, but their runfiles may still be needed in runtime; they currently aren't provided, which seems like a bug (reproduction in gist).