Teach ijar about dynamic constants. #18406
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
awaiting-review
benjaminp
force-pushed
the
benjamin-ijar-dynamic-constant
branch
from
425a5d5 to
0f0abbd
Compare
benjaminp
force-pushed
the
benjamin-ijar-dynamic-constant
branch
from
0f0abbd to
634562d
Compare
sgowroji
added
team-Configurability
Collaborator
|
@bazel-io flag |
bazel-io
added
the
potential release blocker
cushon
approved these changes
Jun 14, 2023
meteorcloudy
added
awaiting-PR-merge
Member
|
@bazel-io fork 6.3.0 |
bazel-io
removed
the
potential release blocker
copybara-service bot
pushed a commit
that referenced
this pull request
Jun 14, 2023
#18360 Partial commit for third_party/*, see #18406. Signed-off-by: Hee Cha <[email protected]>
Member
|
Third party changes merged at: 37c80e8 |
iancha1992
removed
the
awaiting-PR-merge
iancha1992
pushed a commit
to iancha1992/bazel
that referenced
this pull request
Jun 14, 2023
bazelbuild#18360 Partial commit for third_party/*, see bazelbuild#18406. Signed-off-by: Hee Cha <[email protected]>
Collaborator
Author
|
@iancha1992 Thank you for merging. However, there's some kind of extra-special procedure for importing ijar changes. It doesn't seem that was followed in this case, causing the changes to be reverted by the next change (651c451). |
Member
|
@cushon Can you help importing this PR again? |
Contributor
|
Sure, I'm on it: cl/540578976 |
Contributor
|
The change has been imported! 69d2991 |
iancha1992
pushed a commit
to iancha1992/bazel
that referenced
this pull request
Jun 16, 2023
PR bazelbuild#18406: Teach ijar about dynamic constants. Imported from GitHub PR bazelbuild#18406 END_PUBLIC PiperOrigin-RevId: 540750474 Change-Id: If61bcaaf018b92a1bf87335c1075c28294932b1f
iancha1992
pushed a commit
to iancha1992/bazel
that referenced
this pull request
Jun 20, 2023
PR bazelbuild#18406: Teach ijar about dynamic constants. Imported from GitHub PR bazelbuild#18406 END_PUBLIC PiperOrigin-RevId: 540750474 Change-Id: If61bcaaf018b92a1bf87335c1075c28294932b1f
iancha1992
added a commit
that referenced
this pull request
Jun 22, 2023
PR #18406: Teach ijar about dynamic constants. Imported from GitHub PR #18406 END_PUBLIC PiperOrigin-RevId: 540750474 Change-Id: If61bcaaf018b92a1bf87335c1075c28294932b1f Co-authored-by: Benjamin Peterson <[email protected]>
traversaro
pushed a commit
to traversaro/bazel
that referenced
this pull request
Jun 24, 2023
bazelbuild#18360 Partial commit for third_party/*, see bazelbuild#18406. Signed-off-by: Hee Cha <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#18360