Track repo rule label attributes after the first non-existent one #18352
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
awaiting-review
fmeum
force-pushed
the
13441-dont-stop-on-failures
branch
5 times, most recently
from
457c3d7 to
9a1e0cf
Compare
fmeum
commented
May 9, 2023
.../java/com/google/devtools/build/lib/bazel/repository/starlark/StarlarkRepositoryContext.java
Show resolved
Hide resolved
Wyverald
approved these changes
May 10, 2023
.../java/com/google/devtools/build/lib/bazel/repository/starlark/StarlarkRepositoryContext.java
Show resolved
Hide resolved
.../java/com/google/devtools/build/lib/bazel/repository/starlark/StarlarkRepositoryContext.java
Outdated
Show resolved
Hide resolved
Wyverald
added
awaiting-PR-merge
Member
|
Could you sync to HEAD? Some CI infra stuff got changed |
Even with this commit, the fact that a particular label in a repository rule's label attributes does not resolve to a regular file is not tracked, which means that there is still a potential for incorrect incremental fetches. Work towards bazelbuild#13441
fmeum
force-pushed
the
13441-dont-stop-on-failures
branch
from
087c92b to
f18aa51
Compare
Collaborator
Author
@Wyverald Done |
Collaborator
Author
|
CI is still failing with errors that seem unrelated. |
Member
|
yeah so CI is completely on fire now for macos-arm64 and windows. should be unrelated to your changes |
Collaborator
Author
|
@bazel-io flag |
bazel-io
added
the
potential release blocker
Pavank1992
removed
the
awaiting-PR-merge
Member
|
@bazel-io fork 6.3.0 |
bazel-io
removed
the
potential release blocker
iancha1992
pushed a commit
to iancha1992/bazel
that referenced
this pull request
May 15, 2023
Even with this commit, the fact that a particular label in a repository rule's label attributes does not resolve to a regular file is not tracked, which means that there is still a potential for incorrect incremental fetches. Work towards bazelbuild#13441 Closes bazelbuild#18352. PiperOrigin-RevId: 531150549 Change-Id: I086e4813ca88a3f49cde77d9be20adaaf954834b
fweikert
pushed a commit
to fweikert/bazel
that referenced
this pull request
May 25, 2023
Even with this commit, the fact that a particular label in a repository rule's label attributes does not resolve to a regular file is not tracked, which means that there is still a potential for incorrect incremental fetches. Work towards bazelbuild#13441 Closes bazelbuild#18352. PiperOrigin-RevId: 531150549 Change-Id: I086e4813ca88a3f49cde77d9be20adaaf954834b
iancha1992
added a commit
that referenced
this pull request
Jun 6, 2023
…8412) Even with this commit, the fact that a particular label in a repository rule's label attributes does not resolve to a regular file is not tracked, which means that there is still a potential for incorrect incremental fetches. Work towards #13441 Closes #18352. PiperOrigin-RevId: 531150549 Change-Id: I086e4813ca88a3f49cde77d9be20adaaf954834b Co-authored-by: Fabian Meumertzheim <[email protected]> Co-authored-by: keertk <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Even with this commit, the fact that a particular label in a repository rule's label attributes does not resolve to a regular file is not tracked, which means that there is still a potential for incorrect incremental fetches.
Work towards #13441