Ignore hash string casing #18305
Closed
Ignore hash string casing #18305
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes this crash when e.g. the `sha256` attribute is passed an upper
case string:
```
Caused by: java.lang.IllegalArgumentException: Illegal hexadecimal character: D
at com.google.common.hash.HashCode.decode(HashCode.java:360)
at com.google.common.hash.HashCode.fromString(HashCode.java:346)
at com.google.devtools.build.lib.bazel.repository.downloader.Checksum.fromString(Checksum.java:47)
at com.google.devtools.build.lib.bazel.repository.starlark.StarlarkBaseExternalContext.validateChecksum(StarlarkBaseExternalContext.java:302)
at com.google.devtools.build.lib.bazel.repository.starlark.StarlarkBaseExternalContext.downloadAndExtract(StarlarkBaseExternalContext.java:650)
...
```
github-actions
bot
added
awaiting-review
Wyverald
added
awaiting-PR-merge
sgowroji
removed
the
awaiting-PR-merge
Collaborator
Author
|
@bazel-io flag |
bazel-io
added
the
potential release blocker
Member
|
@bazel-io fork 6.3.0 |
bazel-io
removed
the
potential release blocker
iancha1992
pushed a commit
to iancha1992/bazel
that referenced
this pull request
May 15, 2023
Fixes this crash when e.g. the `sha256` attribute is passed an upper case string:
```
Caused by: java.lang.IllegalArgumentException: Illegal hexadecimal character: D
at com.google.common.hash.HashCode.decode(HashCode.java:360)
at com.google.common.hash.HashCode.fromString(HashCode.java:346)
at com.google.devtools.build.lib.bazel.repository.downloader.Checksum.fromString(Checksum.java:47)
at com.google.devtools.build.lib.bazel.repository.starlark.StarlarkBaseExternalContext.validateChecksum(StarlarkBaseExternalContext.java:302)
at com.google.devtools.build.lib.bazel.repository.starlark.StarlarkBaseExternalContext.downloadAndExtract(StarlarkBaseExternalContext.java:650)
...
```
Fixes bazelbuild#18291
Closes bazelbuild#18305.
PiperOrigin-RevId: 529601921
Change-Id: I75deee47bcac80ee81603591c22f43d013ba0c29
fweikert
pushed a commit
to fweikert/bazel
that referenced
this pull request
May 25, 2023
Fixes this crash when e.g. the `sha256` attribute is passed an upper case string:
```
Caused by: java.lang.IllegalArgumentException: Illegal hexadecimal character: D
at com.google.common.hash.HashCode.decode(HashCode.java:360)
at com.google.common.hash.HashCode.fromString(HashCode.java:346)
at com.google.devtools.build.lib.bazel.repository.downloader.Checksum.fromString(Checksum.java:47)
at com.google.devtools.build.lib.bazel.repository.starlark.StarlarkBaseExternalContext.validateChecksum(StarlarkBaseExternalContext.java:302)
at com.google.devtools.build.lib.bazel.repository.starlark.StarlarkBaseExternalContext.downloadAndExtract(StarlarkBaseExternalContext.java:650)
...
```
Fixes bazelbuild#18291
Closes bazelbuild#18305.
PiperOrigin-RevId: 529601921
Change-Id: I75deee47bcac80ee81603591c22f43d013ba0c29
keertk
pushed a commit
that referenced
this pull request
Jun 5, 2023
Fixes this crash when e.g. the `sha256` attribute is passed an upper case string:
```
Caused by: java.lang.IllegalArgumentException: Illegal hexadecimal character: D
at com.google.common.hash.HashCode.decode(HashCode.java:360)
at com.google.common.hash.HashCode.fromString(HashCode.java:346)
at com.google.devtools.build.lib.bazel.repository.downloader.Checksum.fromString(Checksum.java:47)
at com.google.devtools.build.lib.bazel.repository.starlark.StarlarkBaseExternalContext.validateChecksum(StarlarkBaseExternalContext.java:302)
at com.google.devtools.build.lib.bazel.repository.starlark.StarlarkBaseExternalContext.downloadAndExtract(StarlarkBaseExternalContext.java:650)
...
```
Fixes #18291
Closes #18305.
PiperOrigin-RevId: 529601921
Change-Id: I75deee47bcac80ee81603591c22f43d013ba0c29
Co-authored-by: Fabian Meumertzheim <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes this crash when e.g. the
sha256attribute is passed an upper case string:Fixes #18291