Skip to content

Conversation

@meteorcloudy
Copy link
Member

@meteorcloudy meteorcloudy commented Apr 5, 2023

Also storing the change as a separate patch file so that we know what to apply when upgrading zlib (if the problem isn't fixed already).

Fixes #17956

@meteorcloudy meteorcloudy changed the title Patch zlib to fix compatibility with latest Xcode Patch zlib to fix compatibility with Xcode 14.3 Apr 5, 2023
@github-actions github-actions bot added the awaiting-review PR is awaiting review from an assigned reviewer label Apr 5, 2023
@Wyverald Wyverald added awaiting-PR-merge PR has been approved by a reviewer and is ready to be merge internally and removed awaiting-review PR is awaiting review from an assigned reviewer labels Apr 5, 2023
@keertk keertk added the team-OSS Issues for the Bazel OSS team: installation, release processBazel packaging, website label Apr 5, 2023
Copy link
Member

@hvadehra hvadehra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@meteorcloudy
Copy link
Member Author

I'm importing this one.

@copybara-service copybara-service bot closed this in 1f2b3ed Apr 5, 2023
@keertk keertk removed the awaiting-PR-merge PR has been approved by a reviewer and is ready to be merge internally label Apr 5, 2023
ShreeM01 pushed a commit to ShreeM01/bazel that referenced this pull request Apr 5, 2023
Fixes bazelbuild#17956

Partial commit for third_party/*, see bazelbuild#17987.

Closes bazelbuild#17987

Signed-off-by: Yun Peng <[email protected]>
keertk pushed a commit that referenced this pull request Apr 5, 2023
Fixes #17956

Partial commit for third_party/*, see #17987.

Closes #17987

Signed-off-by: Yun Peng <[email protected]>
Co-authored-by: Yun Peng <[email protected]>
ShreeM01 pushed a commit to ShreeM01/bazel that referenced this pull request Apr 5, 2023
Fixes bazelbuild#17956

Partial commit for third_party/*, see bazelbuild#17987.

Closes bazelbuild#17987

Signed-off-by: Yun Peng <[email protected]>
ShreeM01 pushed a commit to ShreeM01/bazel that referenced this pull request Apr 11, 2023
Fixes bazelbuild#17956

Partial commit for third_party/*, see bazelbuild#17987.

Closes bazelbuild#17987

Signed-off-by: Yun Peng <[email protected]>
ShreeM01 added a commit that referenced this pull request Apr 11, 2023
Fixes #17956

Partial commit for third_party/*, see #17987.

Closes #17987

Signed-off-by: Yun Peng <[email protected]>
Co-authored-by: Yun Peng <[email protected]>
ShreeM01 pushed a commit to ShreeM01/bazel that referenced this pull request Apr 11, 2023
Fixes bazelbuild#17956

Partial commit for third_party/*, see bazelbuild#17987.

Closes bazelbuild#17987

Signed-off-by: Yun Peng <[email protected]>
keertk pushed a commit that referenced this pull request Apr 11, 2023
Fixes #17956

Partial commit for third_party/*, see #17987.

Closes #17987

Signed-off-by: Yun Peng <[email protected]>
Co-authored-by: Yun Peng <[email protected]>
keertk pushed a commit that referenced this pull request Apr 12, 2023
Fixes #17956

Partial commit for third_party/*, see #17987.

Closes #17987

Signed-off-by: Yun Peng <[email protected]>
Co-authored-by: Yun Peng <[email protected]>
fweikert pushed a commit to fweikert/bazel that referenced this pull request May 25, 2023
Fixes bazelbuild#17956

Partial commit for third_party/*, see bazelbuild#17987.

Closes bazelbuild#17987

Signed-off-by: Yun Peng <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

team-OSS Issues for the Bazel OSS team: installation, release processBazel packaging, website

Projects

None yet

Development

Successfully merging this pull request may close these issues.

@remote_java_tools fail to build on macOS 13.3 with Xcode 14.3

4 participants