Add support for .tbz file extension in repository_ctx.download_and_extract#17825
Closed
benji-sb wants to merge 1 commit intobazelbuild:masterfrom
Closed
Add support for .tbz file extension in repository_ctx.download_and_extract#17825benji-sb wants to merge 1 commit intobazelbuild:masterfrom
benji-sb wants to merge 1 commit intobazelbuild:masterfrom
Conversation
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
sgowroji
added
team-ExternalDeps
Member
|
Hi @Benjamin-SB, Can you please sign the Google CLA. Thanks! |
benji-sb
force-pushed
the
support-tbz-file-extension
branch
3 times, most recently
from
6a139f9 to
ba3d741
Compare
…tract The `download_and_extract` function supported `.tar.bz2` files, but did not recognize `.tbz` as a valid file extension for those. This commit simply adds support for this, in the code, in the test and in the doc.
benji-sb
force-pushed
the
support-tbz-file-extension
branch
from
ba3d741 to
1d2995e
Compare
Contributor
Author
|
Hi @sgowroji, I was told by my company that they signed the CLA, and that my email address is part of the group that is allowed to contribute to Google OSS. However, I'm afraid the cla/google check still doesn't pass. Is there anything I can do to help for unblocking this? |
Member
|
Did your company just sign the CLA? If so, the process might take a few days. |
Contributor
Author
|
Indeed, the CLA check passed as of today. Sorry for the noise! |
sgowroji
added
awaiting-review
Wyverald
approved these changes
Mar 28, 2023
Wyverald
added
awaiting-PR-merge
sgowroji
removed
the
awaiting-PR-merge
fweikert
pushed a commit
to fweikert/bazel
that referenced
this pull request
May 25, 2023
…tract The `download_and_extract` function supported `.tar.bz2` files, but did not recognize `.tbz` as a valid file extension for those. This commit simply adds support for this, in the code, in the test and in the doc. Fixes bazelbuild#17824 Closes bazelbuild#17825. PiperOrigin-RevId: 520049316 Change-Id: Id4a1716304734f58a06cf5dc8d481642f631f5e1
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
download_and_extractfunction supported.tar.bz2files, but did not recognize.tbzas a valid file extension for those. This commit simply adds support for this, in the code, in the test and in the doc.Fixes #17824