Avoid writing D8 info and error messages directly to the Bazel console #17648
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sgowroji
added
team-Android
Bencodes
force-pushed
the
reduce-console-noise-from-d8
branch
from
7b36574 to
5f7ce78
Compare
Bencodes
changed the title
ahumesky
approved these changes
Aug 17, 2023
ahumesky
added
awaiting-PR-merge
Contributor
|
Hi @Bencodes, Could you please resolve the conflicts at this branch? |
Bencodes
force-pushed
the
reduce-console-noise-from-d8
branch
from
b882fe3 to
38616d9
Compare
Contributor
Author
|
@Pavank1992 this PR has been rebased and is ready to merge. |
github-actions
bot
removed
the
awaiting-PR-merge
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request provides a custom
DiagnosticsHandlerimplementation that redirects info and warning messages to the originalSystem#errstream so that the noisy D8 messages are written to the worker log file instead of directly to the console.In addition this PR also removes the custom system stream redirection, and instead uses the baked in
WorkerIOimplementation that automatically wraps the system stream for us that was added here #14201.#17647