Skip to content

Use rules_jvm_external to fetch jars dependencies (part 1) #17142

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
meteorcloudy wants to merge 1 commit into from
Closed

Use rules_jvm_external to fetch jars dependencies (part 1) #17142

meteorcloudy wants to merge 1 commit into from

Conversation

@meteorcloudy
Copy link
Member

@meteorcloudy meteorcloudy commented Jan 5, 2023

  • Add rules_jvm_external.patch

Merging #17112

@meteorcloudy meteorcloudy requested review from Wyverald and aiuto January 5, 2023 07:02
@meteorcloudy meteorcloudy mentioned this pull request Jan 5, 2023
Closed
@ShreeM01 ShreeM01 added team-ExternalDeps External dependency handling, remote repositiories, WORKSPACE file. awaiting-review PR is awaiting review from an assigned reviewer labels Jan 6, 2023
copybara-service bot pushed a commit that referenced this pull request Jan 10, 2023
@meteorcloudy @copybara-github
Use rules_jvm_external to fetch jars dependencies (part 2)
3d7937e 
- Non-third_party changes in #17112

Merging #17112

Stacking on #17142

Closes #17143.

PiperOrigin-RevId: 500980364
Change-Id: Ie03d4bc8e167d8a27ed8b33cd90f2e3af2c472f6
@meteorcloudy meteorcloudy mentioned this pull request Jan 10, 2023
Closed
hvadehra pushed a commit that referenced this pull request Feb 14, 2023
@meteorcloudy @hvadehra
Use rules_jvm_external to fetch jars dependencies (part 1)
b2c1d4f 
Closes #17142.

Signed-off-by: Yun Peng <[email protected]>
hvadehra pushed a commit that referenced this pull request Feb 14, 2023
@meteorcloudy @hvadehra
Use rules_jvm_external to fetch jars dependencies (part 2)
d803ff8 
- Non-third_party changes in #17112

Merging #17112

Stacking on #17142

Closes #17143.

PiperOrigin-RevId: 500980364
Change-Id: Ie03d4bc8e167d8a27ed8b33cd90f2e3af2c472f6
SalmaSamy pushed a commit that referenced this pull request Apr 19, 2023
@meteorcloudy @SalmaSamy
Use rules_jvm_external to fetch jars dependencies (part 1)
41f8adf 
Closes #17142.

Signed-off-by: Yun Peng <[email protected]>
SalmaSamy pushed a commit that referenced this pull request Apr 19, 2023
@meteorcloudy @SalmaSamy
Use rules_jvm_external to fetch jars dependencies (part 2)
6606fb2 
- Non-third_party changes in #17112

Merging #17112

Stacking on #17142

Closes #17143.

PiperOrigin-RevId: 500980364
Change-Id: Ie03d4bc8e167d8a27ed8b33cd90f2e3af2c472f6

# Conflicts:
#	WORKSPACE
#	maven_install.json
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Wyverald Wyverald Awaiting requested review from Wyverald

1 more reviewer

@aiuto aiuto aiuto approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

awaiting-review PR is awaiting review from an assigned reviewer team-ExternalDeps External dependency handling, remote repositiories, WORKSPACE file.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@meteorcloudy @aiuto @ShreeM01