Update aosp_gradle_core in preparation for updating manifest merger to version 30.1.3 #17014
Conversation
sgowroji
added
team-Android
|
One downside of checking in those jars is that it will forever increase the size of Bazel repository by 7-8 MB, are those jars going to end up in the embedded bazel tools? That would also cause the Bazel binary size to increase. As an alternative, have you considered using rules_jvm_external to fetch those jars instead? |
|
@rjobredeaux3 Can you also update the PR description, thanks! |
rjobredeaux3
changed the title
|
Following Yun's suggestion I have removed the jars from the PR and left it with just the update to aosp_gradle_core. We'll use the work in #17112 to provide the jars via a maven import rule instead |
|
Erm, this can only work once #17112 is submitted and the top-level WORKSPACE file is updated to contain the required android_common dependency |
|
@meteorcloudy Neither Alex nor I have permission to merge this, can you help with next steps? |
|
The gTech team will help us merge third_party change as well, just add the @rjobredeaux3 Can you squash all the commits into one so that it's easier to merge? |
meteorcloudy
added
awaiting-PR-merge
…o version 30.1.3.
Done. |
…o version 30.1.3. Partial commit for third_party/*, see #17014. Signed-off-by: Sunil Gowroji <[email protected]>
|
Merged at 2751985 |
sgowroji
removed
the
awaiting-PR-merge
…o version 30.1.3. Partial commit for third_party/*, see #17014. Signed-off-by: Sunil Gowroji <[email protected]>
4 participants
I'm in the process of updating the version of android_common, which hasn't been done in 6 years. The code under aosp_gradle_core depends on android_common and needs updating in preparation for this. This PR updates the code under aosp_gradle_core to be compatible with version 30.1.3. Since the transition to the new version cannot be atomically done with this change, I've made a copy of the file, on which I've made the required changes.