Allow TemplateDict#map_each callback to return a list of strings
#17008
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Returning a list of strings is needed to get correct `uniquify` semantics when a value may expand to multiple strings.
fmeum
force-pushed
the
template-dict-map-each-list
branch
from
0523af9 to
464f0c1
Compare
Collaborator
Author
|
@hvadehra Could you review? I noticed that I need this functionality. |
sgowroji
added
team-Rules-CPP
hvadehra
approved these changes
Dec 15, 2022
Collaborator
Author
|
@bazel-io flag |
bazel-io
added
the
potential release blocker
Member
|
@bazel-io fork 6.1.0 |
bazel-io
removed
the
potential release blocker
ShreeM01
added a commit
that referenced
this pull request
Jan 26, 2023
…17306) Returning a list of strings is needed to get correct `uniquify` semantics when a value may expand to multiple strings. Work towards #1920 Closes #17008. PiperOrigin-RevId: 495868960 Change-Id: I1f0ec560fd783846e916a07bb524dd2179f7c535 Co-authored-by: Fabian Meumertzheim <[email protected]>
hvadehra
added
team-Rules-API
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Returning a list of strings is needed to get correct
uniquifysemantics when a value may expand to multiple strings.Work towards #1920