Remove LCOV merger dependency of cc_test without coverage
#16994
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When coverage is disabled, `cc_test` should not depend on the Java LCOV merger tool. This is achieved by using `configuration_field`. Also depend on coverage tools in `exec` rather than `target` configuration, matching Java rules.
Collaborator
Author
|
@buildbreaker2021 Can you review? |
buildbreaker2021
approved these changes
Dec 12, 2022
buildbreaker2021
added
the
awaiting-PR-merge
c-mita
approved these changes
Dec 12, 2022
sgowroji
added
the
team-Rules-Server
fmeum
added a commit
to fmeum/bazel
that referenced
this pull request
Dec 13, 2022
When coverage is disabled, `cc_test` should not depend on the Java LCOV merger tool. This is achieved by using `configuration_field`. Also depend on coverage tools in `exec` rather than `target` configuration, matching Java rules as well as the once-per-build coverage report generator. Fixes bazelbuild#16961 Closes bazelbuild#16994. PiperOrigin-RevId: 494941601 Change-Id: Ie614de713b87bb66d869515676698f1a71cb106e
sgowroji
removed
the
awaiting-PR-merge
meteorcloudy
pushed a commit
that referenced
this pull request
Dec 13, 2022
When coverage is disabled, `cc_test` should not depend on the Java LCOV merger tool. This is achieved by using `configuration_field`. Also depend on coverage tools in `exec` rather than `target` configuration, matching Java rules as well as the once-per-build coverage report generator. Fixes #16961 Closes #16994. PiperOrigin-RevId: 494941601 Change-Id: Ie614de713b87bb66d869515676698f1a71cb106e
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When coverage is disabled,
cc_testshould not depend on the Java LCOV merger tool. This is achieved by usingconfiguration_field.Also depend on coverage tools in
execrather thantargetconfiguration, matching Java rules as well as the once-per-build coverage report generator.Fixes #16961