add external_include_paths feature on windows cpp toolchain #16694
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sgowroji
added
team-Rules-CPP
Contributor
Author
|
Bump |
Contributor
|
Hey @lripoche have you verified if this PR fixes two issues you mentioned? |
Contributor
Author
|
Hi @buildbreaker2021, I encountered this bug myself on Windows. This MR fixes it. Both issues do not mention host OS so I can't be sure about it. |
buildbreaker2021
approved these changes
Jan 27, 2023
buildbreaker2021
added
awaiting-PR-merge
sgowroji
removed
the
awaiting-PR-merge
hvadehra
pushed a commit
that referenced
this pull request
Feb 14, 2023
lripoche
added a commit
to lripoche/bazel
that referenced
this pull request
Apr 20, 2023
Potentially fix bazelbuild#15762 and bazelbuild#15865 (if they depend on windows). Linked to 08936ae Closes bazelbuild#16694. PiperOrigin-RevId: 505084880 Change-Id: Ie4dc08a0e93c76419b6164bacccadac32a7c7b2f
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Potentially fix #15762 and #15865 (if they depend on windows).
Linked to 08936ae