Make Bash runfiles library repo mapping aware #16693
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
18 tasks
fmeum
force-pushed
the
16124-bash-current-repository
branch
12 times, most recently
from
7b15eec to
c920817
Compare
Collaborator
Author
|
Stacked on #16652, so please ignore the first commit. |
fmeum
force-pushed
the
16124-bash-current-repository
branch
from
24744f5 to
a261b3b
Compare
fmeum
changed the title
runfiles_current_repository in bash runfiles library
fmeum
force-pushed
the
16124-bash-current-repository
branch
from
a261b3b to
d9d075d
Compare
fmeum
requested review from
Wyverald,
lberki,
meteorcloudy and
oquenchil
as code owners
fmeum
force-pushed
the
16124-bash-current-repository
branch
from
6d7de6b to
b155f93
Compare
Collaborator
Author
|
The test uncovered a minor bug in the runfiles library init code on macOS. Since I am bumping the version anyway, is it okay to keep the fix in this PR? |
ShreeM01
added
team-ExternalDeps
Collaborator
Author
|
@bazel-io flag |
bazel-io
added
the
potential release blocker
Member
|
@bazel-io fork 6.0.0 |
bazel-io
removed
the
potential release blocker
oquenchil
approved these changes
Nov 9, 2022
Wyverald
reviewed
Nov 9, 2022
fmeum
force-pushed
the
16124-bash-current-repository
branch
from
2c9c452 to
0e7c19c
Compare
Wyverald
approved these changes
Nov 9, 2022
Wyverald
added
awaiting-PR-merge
fmeum
force-pushed
the
16124-bash-current-repository
branch
from
0e7c19c to
b3cf14d
Compare
Collaborator
Author
|
Rebased and no longer stacked. |
meteorcloudy
approved these changes
Nov 10, 2022
fmeum
added a commit
to fmeum/bazel
that referenced
this pull request
Nov 11, 2022
Work towards bazelbuild#16124 Closes bazelbuild#16693. PiperOrigin-RevId: 487811689 Change-Id: Iec5ef01ae09394372b87e5cb697ceb728563d2dc
sgowroji
removed
the
awaiting-PR-merge
fmeum
added a commit
to fmeum/bazel
that referenced
this pull request
Nov 15, 2022
Work towards bazelbuild#16124 Closes bazelbuild#16693. PiperOrigin-RevId: 487811689 Change-Id: Iec5ef01ae09394372b87e5cb697ceb728563d2dc
ShreeM01
pushed a commit
that referenced
this pull request
Nov 15, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Work towards #16124