Skip to content

[remote/downloader] Wire credential helper to repository downloads#16682

Closed
Yannic wants to merge 1 commit intobazelbuild:masterfrom
EngFlow:yannic-ch-repo-fetch-hook
Closed

[remote/downloader] Wire credential helper to repository downloads#16682
Yannic wants to merge 1 commit intobazelbuild:masterfrom
EngFlow:yannic-ch-repo-fetch-hook

Conversation

@Yannic
Copy link
Copy Markdown
Contributor

@Yannic Yannic commented Nov 7, 2022

Progress on #16595

@ShreeM01 ShreeM01 added team-Remote-Exec Issues and PRs for the Execution (Remote) team awaiting-user-response Awaiting a response from the author labels Nov 7, 2022
@sgowroji
Copy link
Copy Markdown
Member

Hi @Yannic, Could you please fix the above buildkite errors. Thanks!

@thesayyn
Copy link
Copy Markdown
Contributor

Since credential-helper can set arbitrary headers, how is this going to play out when there's a conflict with existing headers? for instance, bazel sets Accept header, what would be the behavior?

tjgq pushed a commit to tjgq/bazel that referenced this pull request Apr 21, 2023
tjgq pushed a commit to tjgq/bazel that referenced this pull request Apr 28, 2023
@tjgq
Copy link
Copy Markdown
Contributor

tjgq commented May 17, 2023

Since credential-helper can set arbitrary headers, how is this going to play out when there's a conflict with existing headers? for instance, bazel sets Accept header, what would be the behavior?

Both sets of headers will be merged into the request; if there are duplicates, the credential helper wins. (Although I hope this is just a hypothetical example; using Accept as an authorization mechanism sounds like a bad idea.)

(This has now been submitted, see #18173.)

@tjgq tjgq closed this May 17, 2023
@thesayyn
Copy link
Copy Markdown
Contributor

using Accept as an authorization mechanism sounds like a bad idea.

why would that be a limitation? Note that there are valid use cases #17829

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

awaiting-user-response Awaiting a response from the author team-Remote-Exec Issues and PRs for the Execution (Remote) team

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants