Make C++ runfiles library repo mapping aware #16623
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also removes a comment mentioning a `Create` overload that does not exist.
fmeum
force-pushed
the
16124-cc-repo-mapping
branch
from
be7373d to
fbcde7b
Compare
18 tasks
Collaborator
Author
|
@oquenchil @Wyverald Could you review? |
sgowroji
added
team-Rules-CPP
Wyverald
approved these changes
Nov 2, 2022
fmeum
force-pushed
the
16124-cc-repo-mapping
branch
from
d5ee72e to
80074c4
Compare
oquenchil
approved these changes
Nov 3, 2022
oquenchil
added
awaiting-PR-merge
Wyverald
approved these changes
Nov 3, 2022
Member
|
@bazel-io fork 6.0.0 |
sgowroji
removed
the
awaiting-PR-merge
fmeum
added a commit
to fmeum/bazel
that referenced
this pull request
Nov 7, 2022
Also removes a comment mentioning a `Create` overload that does not exist. Work towards bazelbuild#16124 Closes bazelbuild#16623. PiperOrigin-RevId: 486612245 Change-Id: Ib22cadd354c93eb1e113e27b271c639345c20074
Contributor
Collaborator
Author
|
@kshyanashree I think that the test failure is caused by this Git update. It also fails on master with Git 2.38.1. |
Member
|
Yes, we just pushed new docker image for Linux VMs, there seems to be some problem, I have reverted the image version to the last working version, rerun the presubmit should fix the problem. |
Contributor
Ohh I see! Thanks for the info @fmeum |
Contributor
Thanks @meteorcloudy! |
ShreeM01
added a commit
that referenced
this pull request
Nov 7, 2022
Also removes a comment mentioning a `Create` overload that does not exist. Work towards #16124 Closes #16623. PiperOrigin-RevId: 486612245 Change-Id: Ib22cadd354c93eb1e113e27b271c639345c20074 Co-authored-by: Fabian Meumertzheim <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also removes a comment mentioning a
Createoverload that does not exist.Work towards #16124