Make bazel_cc_code_coverage_test more robust against GCC version diff… #16235
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ShreeM01
added
team-Rules-CPP
Member
|
Hmm, looks like there are still some test failures |
…erences * -fprofile-dir shouldn't be used because on the g++ command line because it has different behaviour with different versions (w.r.t. where the output gcda file ends up). * The gcda and gcno files may end up in the same directory as the object file or in the current working directory. * The output of the gcov call in collect_cc_coverage may be "*.gcda.gcov.json.gz" or "*.gcov.json.gz" (as well as the original text file for much older GCC versions). Also re-enable the test for Ubuntu 20.04 pre and postsubmits. Fixes bazelbuild#16229
c-mita
force-pushed
the
fix_collect_cc_coverage_test
branch
from
d38c739 to
3cc009b
Compare
Member
Author
Fixed, I hope... ;) |
meteorcloudy
approved these changes
Sep 8, 2022
oquenchil
added
awaiting-review
meteorcloudy
pushed a commit
to meteorcloudy/bazel
that referenced
this pull request
Sep 12, 2022
…erences * -fprofile-dir shouldn't be used because on the g++ command line because it has different behaviour with different versions (w.r.t. where the output gcda file ends up). * The gcda and gcno files may end up in the same directory as the object file or in the current working directory. * The output of the gcov call in collect_cc_coverage may be "*.gcda.gcov.json.gz" or "*.gcov.json.gz" (as well as the original text file for much older GCC versions). Also re-enable the test for Ubuntu 20.04 pre and postsubmits. Fixes bazelbuild#16229 Closes bazelbuild#16235. PiperOrigin-RevId: 473218955 Change-Id: I1f4887f251da8f56f8ea525c1a1410e6257bf31b
ShreeM01
pushed a commit
that referenced
this pull request
Sep 12, 2022
…erences (#16254) * -fprofile-dir shouldn't be used because on the g++ command line because it has different behaviour with different versions (w.r.t. where the output gcda file ends up). * The gcda and gcno files may end up in the same directory as the object file or in the current working directory. * The output of the gcov call in collect_cc_coverage may be "*.gcda.gcov.json.gz" or "*.gcov.json.gz" (as well as the original text file for much older GCC versions). Also re-enable the test for Ubuntu 20.04 pre and postsubmits. Fixes #16229 Closes #16235. PiperOrigin-RevId: 473218955 Change-Id: I1f4887f251da8f56f8ea525c1a1410e6257bf31b Co-authored-by: Charles Mita <[email protected]>
ShreeM01
removed
the
awaiting-review
aiuto
pushed a commit
to aiuto/bazel
that referenced
this pull request
Oct 12, 2022
…erences * -fprofile-dir shouldn't be used because on the g++ command line because it has different behaviour with different versions (w.r.t. where the output gcda file ends up). * The gcda and gcno files may end up in the same directory as the object file or in the current working directory. * The output of the gcov call in collect_cc_coverage may be "*.gcda.gcov.json.gz" or "*.gcov.json.gz" (as well as the original text file for much older GCC versions). Also re-enable the test for Ubuntu 20.04 pre and postsubmits. Fixes bazelbuild#16229 Closes bazelbuild#16235. PiperOrigin-RevId: 473218955 Change-Id: I1f4887f251da8f56f8ea525c1a1410e6257bf31b
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…erences
Also re-enable the test for Ubuntu 20.04 pre and postsubmits.
Fixes #16229