Do not crash on URIs without a host component.#16184
Closed
tjgq wants to merge 1 commit intobazelbuild:masterfrom
Closed
Do not crash on URIs without a host component.#16184tjgq wants to merge 1 commit intobazelbuild:masterfrom
tjgq wants to merge 1 commit intobazelbuild:masterfrom
Conversation
tjgq
force-pushed
the
unix
branch
2 times, most recently
from
7979b32 to
85b5e24
Compare
Yannic
approved these changes
Aug 29, 2022
Contributor
Yannic
left a comment
Yannic
left a comment
There was a problem hiding this comment.
A regression test in CredentialHelperProviderTest would be nice :)
|
|
||
| String host = Preconditions.checkNotNull(uri.getHost()); | ||
| String host = uri.getHost(); | ||
| if (host == null) { |
Contributor
There was a problem hiding this comment.
Maybe use Guava's Strings.isNullOrEmpty() here?
URIs such as `unix://...` (Unix domain socket) may legitimately be missing a host component. We should gracefully handle them when looking for a credential helper (no such helper can exist for them since the lookup is host-based, but this could change in the future). Fixes bazelbuild#16171 which is a regression in 5.3. We had some tests for this in remote_execution_test.sh, but they were disabled due to flakiness in 8e3c0df. I've filed bazelbuild#16185 to reenable them.
Contributor
Author
Done. |
sgowroji
added
team-Remote-Exec
Contributor
|
@bazel-io fork 5.3.1 |
ShreeM01
added a commit
that referenced
this pull request
Aug 31, 2022
URIs such as `unix://...` (Unix domain socket) may legitimately be missing a host component. We should gracefully handle them when looking for a credential helper (no such helper can exist for them since the lookup is host-based, but this could change in the future). Fixes #16171 which is a regression in 5.3. We had some tests for this in remote_execution_test.sh, but they were disabled due to flakiness in 8e3c0df. I've filed #16185 to reenable them. Closes #16184. PiperOrigin-RevId: 470724658 Change-Id: Ibd7203546f00fe2335c14e7a5fa6d5bf64868bac Co-authored-by: Tiago Quelhas <[email protected]>
ShreeM01
removed
the
awaiting-review
aiuto
pushed a commit
to aiuto/bazel
that referenced
this pull request
Oct 12, 2022
URIs such as `unix://...` (Unix domain socket) may legitimately be missing a host component. We should gracefully handle them when looking for a credential helper (no such helper can exist for them since the lookup is host-based, but this could change in the future). Fixes bazelbuild#16171 which is a regression in 5.3. We had some tests for this in remote_execution_test.sh, but they were disabled due to flakiness in 8e3c0df. I've filed bazelbuild#16185 to reenable them. Closes bazelbuild#16184. PiperOrigin-RevId: 470724658 Change-Id: Ibd7203546f00fe2335c14e7a5fa6d5bf64868bac
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
URIs such as
unix://...(Unix domain socket) may legitimately be missing ahost component. We should gracefully handle them when looking for a credential
helper (no such helper can exist for them since the lookup is host-based, but
this could change in the future).
Fixes #16171 which is a regression in 5.3. We had some tests for this in
remote_execution_test.sh, but they were disabled due to flakiness in 8e3c0df.
I've filed #16185 to reenable them.