Save injected metadata in RemoteActionFileSystem#16123
Closed
coeuvre wants to merge 3 commits intobazelbuild:masterfrom
Closed
Save injected metadata in RemoteActionFileSystem#16123coeuvre wants to merge 3 commits intobazelbuild:masterfrom
coeuvre wants to merge 3 commits intobazelbuild:masterfrom
Conversation
…s can be accesssed among spwans within on action execution
tjgq
approved these changes
Aug 18, 2022
Contributor
|
Should we cherry-pick this into 5.3? |
sgowroji
added
team-Remote-Exec
Member
Author
|
I am fine to cherry-pick this into 5.3 but not sure whether it is still possible now to do so given that we are releasing 5.3 soon. cc @kshyanashree |
Contributor
|
I'll flag it, and it can get rejected/moved to the next release if it's too late. |
Contributor
|
@bazel-io flag |
bazel-io
added
the
potential release blocker
ShreeM01
removed
the
awaiting-review
This was referenced Sep 29, 2022
Closed
aiuto
pushed a commit
to aiuto/bazel
that referenced
this pull request
Oct 12, 2022
So that spawn outputs can be accessed among Spwans within the same action using the `FileSystem` API. This allow us to revert the hack we introduced in bazelbuild#12590. Also fixes the issue described by bazelbuild#15711. Closes bazelbuild#15711. Closes bazelbuild#16123. PiperOrigin-RevId: 469133936 Change-Id: Ide5bcfa0fe2c6a3806d333cd61270e411aa78f80
Member
|
This should be in 6.0, removing the "potential release blocker" label. |
meteorcloudy
removed
the
potential release blocker
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
So that spawn outputs can be accessed among Spwans within the same action using the
FileSystemAPI.This allow us to revert the hack we introduced in #12590. Also fixes the issue described by #15711.
Closes #15711.