Add .wasm cc artifact executable extension #16091
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This allows using a cc_toolchain that compiles to WebAssembly that outputs a wasm file with the standard extension, without needing to have a genrule that renames the file
sgowroji
added
team-Rules-CPP
oquenchil
approved these changes
Dec 16, 2022
oquenchil
added
awaiting-PR-merge
sgowroji
removed
the
awaiting-PR-merge
zaucy
pushed a commit
to zaucy/bazel
that referenced
this pull request
Feb 8, 2023
This allows creating a custom cc_toolchain that compiles to WebAssembly that outputs a wasm file with the standard extension, without needing to have a genrule that renames the file Closes bazelbuild#16091. PiperOrigin-RevId: 503921110 Change-Id: I3ed9e50a945d2e415e2ab34bd99ceea481c987f0
zaucy
added a commit
to zaucy/bazel
that referenced
this pull request
Feb 8, 2023
Similar to bazelbuild#16091 except also allow the `.wasm` extension for dynamic libraries. Closes bazelbuild#17374. PiperOrigin-RevId: 507668339 Change-Id: Id85f98bb804e573e5f93a922b67baf75a22baf16
hvadehra
pushed a commit
that referenced
this pull request
Feb 14, 2023
This allows creating a custom cc_toolchain that compiles to WebAssembly that outputs a wasm file with the standard extension, without needing to have a genrule that renames the file Closes #16091. PiperOrigin-RevId: 503921110 Change-Id: I3ed9e50a945d2e415e2ab34bd99ceea481c987f0
keertk
pushed a commit
that referenced
this pull request
Feb 28, 2023
* Add .wasm cc artifact executable extension This allows creating a custom cc_toolchain that compiles to WebAssembly that outputs a wasm file with the standard extension, without needing to have a genrule that renames the file Closes #16091. PiperOrigin-RevId: 503921110 Change-Id: I3ed9e50a945d2e415e2ab34bd99ceea481c987f0 * Add .wasm cc dynamic library extension Similar to #16091 except also allow the `.wasm` extension for dynamic libraries. Closes #17374. PiperOrigin-RevId: 507668339 Change-Id: Id85f98bb804e573e5f93a922b67baf75a22baf16 --------- Co-authored-by: Scott Bennett <[email protected]> Co-authored-by: kshyanashree <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows creating a custom cc_toolchain that compiles to WebAssembly that outputs a wasm file with the standard extension, without needing to have a genrule that renames the file