Add option to git_repository to provide build file / content#16064
Closed
limdor wants to merge 1 commit intobazelbuild:masterfrom
Closed
Add option to git_repository to provide build file / content#16064limdor wants to merge 1 commit intobazelbuild:masterfrom
limdor wants to merge 1 commit intobazelbuild:masterfrom
Conversation
aiuto
approved these changes
Aug 14, 2022
|
I'll merge this. |
aiuto
pushed a commit
to aiuto/bazel
that referenced
this pull request
Oct 12, 2022
This PR moves the extra features of new_git_repository to git_repository and makes new_git_repository and alias to git_repository. A side effect is that new_git_repository should disappear from documentation. Discussion: https://groups.google.com/g/bazel-dev/c/sfeRE3Ucj7E Future work: - Wait until Bazel 6.x goes out, then remove the new_git_repository alias Closes bazelbuild#16064. PiperOrigin-RevId: 467925617 Change-Id: I94508f559f84721f7bb880323d1dd53c6e19682b
copybara-service Bot
pushed a commit
that referenced
this pull request
Mar 16, 2023
Requiring either `build_file` or `build_file_content` is no longer true after #16064 PiperOrigin-RevId: 517095299 Change-Id: Ifd32a50b633345048c1ee620d1883637ce85391f
fweikert
pushed a commit
to fweikert/bazel
that referenced
this pull request
May 25, 2023
Requiring either `build_file` or `build_file_content` is no longer true after bazelbuild#16064 PiperOrigin-RevId: 517095299 Change-Id: Ifd32a50b633345048c1ee620d1883637ce85391f
fhanau
added a commit
to cloudflare/workerd
that referenced
this pull request
Jan 19, 2024
- Based on bazelbuild/bazel#16064 git_repository supports the same arguments as new_git_repository and the latter should no longer be used. - Update documentation to reflect that v8 is now used as a http_archive dependency.
fhanau
added a commit
to cloudflare/workerd
that referenced
this pull request
Jan 23, 2024
- Based on bazelbuild/bazel#16064 git_repository supports the same arguments as new_git_repository and the latter should no longer be used. - Update documentation to reflect that v8 is now used as a http_archive dependency.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is just a first draft from the discussion we had with @aiuto in https://groups.google.com/g/bazel-dev/c/sfeRE3Ucj7E just to see what the CI says about it.
Before this can be proposed to be merged, I see several topics to tackle:
Probably we should also create an issue to track it.